Re: [3/5] 2.6.21-rc4: known regressions (v2)

Rafael J. Wysocki
2007-03-25T19:11:10Z

On Sunday, 25 March 2007 19:25, Thomas Meyer wrote:
> Adrian Bunk schrieb:
> > On Sun, Mar 25, 2007 at 01:41:33PM +0200, Thomas Meyer wrote:
> >
> >> ...
> >> The first suspend to disk is ok. The second suspend to disk has a
> >> strange behaviour:
> >> 1.) write pm image
> >> 2.) the system disable the non-boot cpus again (i guess this happens in
> >> power_down())
> >> 3.) the system doesn't power down.
> >> 4.) pressing any key and the system powers down.
> >> ...
> >>
> >
> > Is this also present with 2.6.20, or is it a regression?
> >
> No, this one is not present in 2.6.20 and this error doesn't (head=
> 317ec6cd00f25d05d153a780bc178c5335f320ee) occur with NO_HZ=n and
> HIGH_RES_TIMERS=n
>
> This error is maybe related with this commit:

Yes, it is, but I'd rather remove the disable_nonboot_cpus() from
power_down() (as Eric suggested) instead of trying to handle the RCU sync
problem here.

This has been caused by my commit 94985134b7b46848267ed6b734320db01c974e72
(swsusp: disable nonboot CPUs before entering platform suspend) that in such a
case should be reverted.

Greetings,
Rafael