From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965309AbXC0HgE (ORCPT ); Tue, 27 Mar 2007 03:36:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965322AbXC0HgE (ORCPT ); Tue, 27 Mar 2007 03:36:04 -0400 Received: from smtp.osdl.org ([65.172.181.24]:43763 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965309AbXC0HgB (ORCPT ); Tue, 27 Mar 2007 03:36:01 -0400 Date: Mon, 26 Mar 2007 23:35:58 -0800 From: Andrew Morton To: Miklos Szeredi Cc: linux-kernel@vger.kernel.org Subject: Re: [patch] add file position info to proc Message-Id: <20070326233558.9254cdfc.akpm@linux-foundation.org> In-Reply-To: References: <20070326174535.4f21bed3.akpm@linux-foundation.org> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Mar 2007 09:08:35 +0200 Miklos Szeredi wrote: > > > This patch adds support for finding out the current file position, > > > open flags and possibly other info in the future. > > > > fs/proc/base.c: In function 'proc_lookupfdinfo': > > fs/proc/base.c:1584: warning: passing argument 3 of 'proc_lookupfd_common' from incompatible pointer type > > fs/proc/base.c: In function 'proc_readfdinfo': > > fs/proc/base.c:1590: warning: passing argument 4 of 'proc_readfd_common' from incompatible pointer type > > > > If taken, that callback into proc_lookupfd_common() will crash the kernel. > > Ugh. Some constification in -mm that I hadn't noticed. Resending. > OK, I misread the code. I fixed it up.