public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: bryan.wu@analog.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Paul Mundt <lethal@linux-sh.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] Blackfin arch: add kdebug header file
Date: Mon, 26 Mar 2007 23:45:08 +0200	[thread overview]
Message-ID: <200703262345.09489.arnd@arndb.de> (raw)
In-Reply-To: <1174903941.32691.72.camel@roc-desktop>

I can see nothing wrong with your patches, but you should make the
patch descriptions a little clearer:

On Monday 26 March 2007, Wu, Bryan wrote:
> Hi folks,

No need for this line, if it's there, Andrew just needs to remove
it from the changelog.

> This patch adds kdebug.h header file to blackfin architecture.

This line is completely redundant, as it states the same information
as the subject. You should give some background information here,
like:

kdebug.h is needed for kprobes.

For trivial patches where the subject already tells the whole story
(e.g. 'remove redundant declaration of foo'), just leave out the
description entirely except for the Signed-off-by.

	Arnd <><
you can even leave out the description

  reply	other threads:[~2007-03-26 21:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26 10:12 [PATCH -mm] Blackfin arch: add kdebug header file Wu, Bryan
2007-03-26 21:45 ` Arnd Bergmann [this message]
2007-03-27  3:40   ` Wu, Bryan
2007-03-27  3:57     ` Paul Mundt
2007-03-27  4:34       ` Mike Frysinger
2007-03-27  4:49         ` Paul Mundt
2007-03-27  5:17           ` Mike Frysinger
2007-03-27  5:27             ` Randy Dunlap
2007-03-27  5:40               ` Wu, Bryan
2007-03-27  8:27                 ` Sam Ravnborg
2007-03-27 15:34                 ` Randy Dunlap
2007-03-28  2:06                   ` Wu, Bryan
2007-03-28  2:13                     ` Randy Dunlap
2007-03-27  5:32             ` Wu, Bryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703262345.09489.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=bryan.wu@analog.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox