* [PATCH 1/6] i386 - fix cmpxchg warning
@ 2007-03-27 18:27 Jeff Dike
2007-03-28 19:05 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Dike @ 2007-03-27 18:27 UTC (permalink / raw)
To: Andi Kleen, Andrew Morton; +Cc: LKML, uml-devel
I started getting warnings from atomic.h about cmpxchg not having a
prototype. It's declared in system.h, so including that fixes the UML
build warnings and has no noticable ill effects on the i386 build.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
include/asm-i386/atomic.h | 1 +
1 file changed, 1 insertion(+)
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
Index: linux-2.6.21-mm/include/asm-i386/atomic.h
===================================================================
--- linux-2.6.21-mm.orig/include/asm-i386/atomic.h 2007-03-27 12:25:16.000000000 -0400
+++ linux-2.6.21-mm/include/asm-i386/atomic.h 2007-03-27 12:26:38.000000000 -0400
@@ -3,6 +3,7 @@
#include <linux/compiler.h>
#include <asm/processor.h>
+#include <asm/system.h>
/*
* Atomic operations that C can't guarantee us. Useful for
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/6] i386 - fix cmpxchg warning
2007-03-27 18:27 [PATCH 1/6] i386 - fix cmpxchg warning Jeff Dike
@ 2007-03-28 19:05 ` Andi Kleen
2007-03-29 18:32 ` Jeff Dike
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2007-03-28 19:05 UTC (permalink / raw)
To: Jeff Dike; +Cc: Andrew Morton, LKML, uml-devel
> #include <linux/compiler.h>
> #include <asm/processor.h>
> +#include <asm/system.h>
Sorry no. system.h is the header from hell and putting it into a "basic" header
like atomic_t will likely cause all kinds of problems.
If it's a real issue move cmpxchhg into a different header and include that
from system.h and atomic.h. system.h has too much stuff anyways so it could
use any cleanup.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/6] i386 - fix cmpxchg warning
2007-03-28 19:05 ` Andi Kleen
@ 2007-03-29 18:32 ` Jeff Dike
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Dike @ 2007-03-29 18:32 UTC (permalink / raw)
To: Andi Kleen; +Cc: Andrew Morton, LKML, uml-devel
On Wed, Mar 28, 2007 at 09:05:03PM +0200, Andi Kleen wrote:
>
> > #include <linux/compiler.h>
> > #include <asm/processor.h>
> > +#include <asm/system.h>
> Sorry no. system.h is the header from hell and putting it into a
> "basic" header like atomic_t will likely cause all kinds of
> problems.
OK, I'll figure out someplace else for it.
Jeff
--
Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-30 1:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-27 18:27 [PATCH 1/6] i386 - fix cmpxchg warning Jeff Dike
2007-03-28 19:05 ` Andi Kleen
2007-03-29 18:32 ` Jeff Dike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox