Re: [-mm patch] fix arch/i386/kernel/marker.c compilation

Mathieu Desnoyers
2007-03-27T17:11:54Z

Hi Adrian,

Since kdebug.h seems to have moved from asm/ to linux/ in Andrew's tree, I
guess the #include <asm/kdebug.h> should be removed ? linux/kdebug.h
already includes asm/kdebug.h.

Mathieu

* Adrian Bunk (bunk@stusta.de) wrote:
> On Mon, Mar 26, 2007 at 08:57:06PM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.21-rc4-mm1:
> >...
> > +move-die-notifier-handling-to-common-code.patch
> >...
> > Misc
> >...
>
>
> This patch fixes the following compile error:
>
> <-- snip -->
>
> ...
> CC arch/i386/kernel/marker.o
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c: In function 'mark_notifier':
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:44: error: dereferencing pointer to incomplete type
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:44: error: dereferencing pointer to incomplete type
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:47: error: dereferencing pointer to incomplete type
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:48: error: dereferencing pointer to incomplete type
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c: In function 'marker_optimized_set_enable':
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:69: error: implicit declaration of function 'register_die_notifier'
> /home/bunk/linux/kernel-2.6/linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c:87: error: implicit declaration of function 'unregister_die_notifier'
> make[2]: *** [arch/i386/kernel/marker.o] Error 1
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
> --- linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c.old 2007-03-27 18:46:49.000000000 +0200
> +++ linux-2.6.21-rc5-mm2/arch/i386/kernel/marker.c 2007-03-27 18:47:14.000000000 +0200
> @@ -16,6 +16,7 @@
> #include <linux/notifier.h>
> #include <linux/module.h>
> #include <linux/marker.h>
> +#include <linux/kdebug.h>
> #include <asm/cacheflush.h>
> #include <asm/kdebug.h>
>
>

--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68