From: Zach Brown <zach.brown@oracle.com>
To: linux-aio@kvack.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] aio: remove bare user-triggerable error printk
Date: Tue, 27 Mar 2007 15:44:01 -0700 (PDT) [thread overview]
Message-ID: <20070327224401.17758.17852.sendpatchset@tetsuo.zabbo.net> (raw)
aio: remove bare user-triggerable error printk
The user can generate console output if they cause do_mmap() to fail during
sys_io_setup(). This was seen in a regression test that does exactly that by
spinning calling mmap() until it gets -ENOMEM before calling io_setup().
We don't need this printk all, just remove it.
Signed-off-by: Zach Brown <zach.brown@oracle.com>
---
fs/aio.c | 1 -
1 file changed, 1 deletion(-)
--- a/fs/aio.c Tue Mar 27 14:56:08 2007 -0700
+++ b/fs/aio.c Tue Mar 27 14:56:49 2007 -0700
@@ -136,7 +136,6 @@ static int aio_setup_ring(struct kioctx
0);
if (IS_ERR((void *)info->mmap_base)) {
up_write(&ctx->mm->mmap_sem);
- printk("mmap err: %ld\n", -info->mmap_base);
info->mmap_size = 0;
aio_free_ring(ctx);
return -EAGAIN;
next reply other threads:[~2007-03-27 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 22:44 Zach Brown [this message]
2007-03-27 22:49 ` [PATCH] aio: remove bare user-triggerable error printk Zach Brown
2007-03-27 23:42 ` Benjamin LaHaise
2007-03-28 13:58 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070327224401.17758.17852.sendpatchset@tetsuo.zabbo.net \
--to=zach.brown@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox