From: Pete Zaitcev <zaitcev@redhat.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel-list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB Elan FTDI: check for driver registration status
Date: Wed, 28 Mar 2007 11:41:25 -0700 [thread overview]
Message-ID: <20070328114125.d4f2e650.zaitcev@redhat.com> (raw)
In-Reply-To: <20070328160032.GA10233@cvg>
On Wed, 28 Mar 2007 20:00:32 +0400, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> result = usb_register(&ftdi_elan_driver);
> - if (result)
> + if (result) {
> + destroy_workqueue(status_queue);
> + destroy_workqueue(command_queue);
> + destroy_workqueue(respond_queue);
> printk(KERN_ERR "usb_register failed. Error number %d\n",
> result);
I would just change the printk from "couldn't create workqueue"
to something more neutral, but this is ok too. Let's just declare
it fixed and move on.
-- Pete
next prev parent reply other threads:[~2007-03-28 18:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-25 7:27 [PATCH] USB Elan FTDI: check for driver registration status Cyrill Gorcunov
2007-03-26 18:43 ` Luiz Fernando N. Capitulino
2007-03-26 19:33 ` Cyrill Gorcunov
2007-03-26 19:56 ` Luiz Fernando N. Capitulino
2007-03-28 16:00 ` Cyrill Gorcunov
2007-03-28 18:41 ` Pete Zaitcev [this message]
2007-03-26 22:17 ` Pete Zaitcev
2007-03-27 15:14 ` Cyrill Gorcunov
2007-03-27 16:28 ` Luiz Fernando N. Capitulino
2007-03-27 17:01 ` Cyrill Gorcunov
2007-03-27 17:29 ` Luiz Fernando N. Capitulino
2007-03-27 17:37 ` Cyrill Gorcunov
2007-03-27 17:51 ` Pete Zaitcev
2007-03-27 18:16 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070328114125.d4f2e650.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox