From: Adrian Bunk <bunk@stusta.de>
To: linux-kernel@vger.kernel.org, ak@suse.de
Cc: discuss@x86-64.org
Subject: [2.6 patch] i386/x86_64: sys_ioperm() prototype cleanup
Date: Wed, 28 Mar 2007 14:11:02 +0200 [thread overview]
Message-ID: <20070328121101.GN16477@stusta.de> (raw)
- there's no reason for duplicating the prototype from
include/linux/syscalls.h in include/asm-x86_64/unistd.h
- every file should #include the headers containing the prototypes for
it's global functions
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
arch/i386/kernel/ioport.c | 1 +
arch/x86_64/kernel/ioport.c | 1 +
include/asm-x86_64/unistd.h | 1 -
3 files changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.21-rc4-mm1/include/asm-x86_64/unistd.h.old 2007-03-26 15:45:56.000000000 +0200
+++ linux-2.6.21-rc4-mm1/include/asm-x86_64/unistd.h 2007-03-26 15:46:05.000000000 +0200
@@ -655,7 +655,6 @@
#include <asm/ptrace.h>
asmlinkage long sys_iopl(unsigned int level, struct pt_regs *regs);
-asmlinkage long sys_ioperm(unsigned long from, unsigned long num, int turn_on);
struct sigaction;
asmlinkage long sys_rt_sigaction(int sig,
const struct sigaction __user *act,
--- linux-2.6.21-rc4-mm1/arch/i386/kernel/ioport.c.old 2007-03-26 15:44:17.000000000 +0200
+++ linux-2.6.21-rc4-mm1/arch/i386/kernel/ioport.c 2007-03-26 15:44:39.000000000 +0200
@@ -16,6 +16,7 @@
#include <linux/stddef.h>
#include <linux/slab.h>
#include <linux/thread_info.h>
+#include <linux/syscalls.h>
/* Set EXTENT bits starting at BASE in BITMAP to value TURN_ON. */
static void set_bitmap(unsigned long *bitmap, unsigned int base, unsigned int extent, int new_value)
--- linux-2.6.21-rc4-mm1/arch/x86_64/kernel/ioport.c.old 2007-03-26 15:43:45.000000000 +0200
+++ linux-2.6.21-rc4-mm1/arch/x86_64/kernel/ioport.c 2007-03-26 15:44:01.000000000 +0200
@@ -16,6 +16,7 @@
#include <linux/stddef.h>
#include <linux/slab.h>
#include <linux/thread_info.h>
+#include <linux/syscalls.h>
/* Set EXTENT bits starting at BASE in BITMAP to value TURN_ON. */
static void set_bitmap(unsigned long *bitmap, unsigned int base, unsigned int extent, int new_value)
reply other threads:[~2007-03-28 12:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070328121101.GN16477@stusta.de \
--to=bunk@stusta.de \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox