* [2.6 patch] i386/x86_64: sys_ioperm() prototype cleanup
@ 2007-03-28 12:11 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2007-03-28 12:11 UTC (permalink / raw)
To: linux-kernel, ak; +Cc: discuss
- there's no reason for duplicating the prototype from
include/linux/syscalls.h in include/asm-x86_64/unistd.h
- every file should #include the headers containing the prototypes for
it's global functions
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
arch/i386/kernel/ioport.c | 1 +
arch/x86_64/kernel/ioport.c | 1 +
include/asm-x86_64/unistd.h | 1 -
3 files changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.21-rc4-mm1/include/asm-x86_64/unistd.h.old 2007-03-26 15:45:56.000000000 +0200
+++ linux-2.6.21-rc4-mm1/include/asm-x86_64/unistd.h 2007-03-26 15:46:05.000000000 +0200
@@ -655,7 +655,6 @@
#include <asm/ptrace.h>
asmlinkage long sys_iopl(unsigned int level, struct pt_regs *regs);
-asmlinkage long sys_ioperm(unsigned long from, unsigned long num, int turn_on);
struct sigaction;
asmlinkage long sys_rt_sigaction(int sig,
const struct sigaction __user *act,
--- linux-2.6.21-rc4-mm1/arch/i386/kernel/ioport.c.old 2007-03-26 15:44:17.000000000 +0200
+++ linux-2.6.21-rc4-mm1/arch/i386/kernel/ioport.c 2007-03-26 15:44:39.000000000 +0200
@@ -16,6 +16,7 @@
#include <linux/stddef.h>
#include <linux/slab.h>
#include <linux/thread_info.h>
+#include <linux/syscalls.h>
/* Set EXTENT bits starting at BASE in BITMAP to value TURN_ON. */
static void set_bitmap(unsigned long *bitmap, unsigned int base, unsigned int extent, int new_value)
--- linux-2.6.21-rc4-mm1/arch/x86_64/kernel/ioport.c.old 2007-03-26 15:43:45.000000000 +0200
+++ linux-2.6.21-rc4-mm1/arch/x86_64/kernel/ioport.c 2007-03-26 15:44:01.000000000 +0200
@@ -16,6 +16,7 @@
#include <linux/stddef.h>
#include <linux/slab.h>
#include <linux/thread_info.h>
+#include <linux/syscalls.h>
/* Set EXTENT bits starting at BASE in BITMAP to value TURN_ON. */
static void set_bitmap(unsigned long *bitmap, unsigned int base, unsigned int extent, int new_value)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-03-28 12:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-28 12:11 [2.6 patch] i386/x86_64: sys_ioperm() prototype cleanup Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox