From: Andi Kleen <ak@suse.de>
To: Jeff Dike <jdike@addtoit.com>
Cc: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH 1/6] i386 - fix cmpxchg warning
Date: Wed, 28 Mar 2007 21:05:03 +0200 [thread overview]
Message-ID: <200703282105.03832.ak@suse.de> (raw)
In-Reply-To: <20070327182746.GA8395@c2.user-mode-linux.org>
> #include <linux/compiler.h>
> #include <asm/processor.h>
> +#include <asm/system.h>
Sorry no. system.h is the header from hell and putting it into a "basic" header
like atomic_t will likely cause all kinds of problems.
If it's a real issue move cmpxchhg into a different header and include that
from system.h and atomic.h. system.h has too much stuff anyways so it could
use any cleanup.
-Andi
next prev parent reply other threads:[~2007-03-28 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 18:27 [PATCH 1/6] i386 - fix cmpxchg warning Jeff Dike
2007-03-28 19:05 ` Andi Kleen [this message]
2007-03-29 18:32 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703282105.03832.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox