From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753146AbXC1V2r (ORCPT ); Wed, 28 Mar 2007 17:28:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753148AbXC1V2r (ORCPT ); Wed, 28 Mar 2007 17:28:47 -0400 Received: from cavan.codon.org.uk ([217.147.92.49]:55461 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753110AbXC1V2k (ORCPT ); Wed, 28 Mar 2007 17:28:40 -0400 Date: Wed, 28 Mar 2007 22:28:29 +0100 From: Matthew Garrett To: Alan Cox Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, kyle@canonical.com Message-ID: <20070328212829.GA14263@srcf.ucam.org> References: <20070323191321.5d00887a@lxorguk.ukuu.org.uk> <20070328000851.GA25551@srcf.ucam.org> <20070328105754.72b578bd@the-village.bc.nu> <20070328200829.GA12776@srcf.ucam.org> <20070328225431.69d0a3cc@the-village.bc.nu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070328225431.69d0a3cc@the-village.bc.nu> User-Agent: Mutt/1.5.12-2006-07-14 X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@codon.org.uk Subject: Re: HPA patches X-SA-Exim-Version: 4.2.1 (built Tue, 20 Jun 2006 01:35:45 +0000) X-SA-Exim-Scanned: Yes (on vavatch.codon.org.uk) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 28, 2007 at 10:54:31PM +0100, Alan Cox wrote: > I wonder if the firmware is dying when we ask the disk to go zero sized > rather than erroring politely. I'm not sure hth HPA sectors can come back > as zero but we can be fairly sure 0 means "no HPA" in this case I guess ? No, it seems to be looking at 0 because ata_read_native_max_address_ext returns 0 in the error case - the error that ata_exec_internal generates seems to be AC_ERR_HSM. Since 0 isn't > the size reported, we'll never try to resize it anyway, judging by ata_hpa_resize - that is, it seems to be the ata_read_native_max_address_ext call that breaks it. -- Matthew Garrett | mjg59@srcf.ucam.org