Re: [PATCH] i386: add command line option "local_apic_timer_c2_ok"

Linus Torvalds
2007-03-27T21:45:40Z

On Tue, 27 Mar 2007, Len Brown wrote:
>
> I think the only fool-proof way to do this automatically is to

Why not just take the known-good CPUID signature?

Screw firmware or ACPI tables. They're going to be occasionally wrong.

If we know that "Core 2, version X" has a good local APIC timer, we use
it. Otherwise we don't.

That's generally how we handle other APIC bugs too (the read-after-write
thing, for example, or the differences between integrated and off-chip
APIC's). Sometimes we check the APIC version itself, sometimes we check
the CPUID information, and sometimes we check both ("modern_apic()").

Linus