Re: [PATCH] i386: add command line option "local_apic_timer_c2_ok"

Andi Kleen
2007-03-29T22:06:51Z

On Thursday 29 March 2007 23:45, Andreas Mohr wrote:
> Hi,
>
> On Thu, Mar 29, 2007 at 02:16:54PM -0700, Linus Torvalds wrote:
> >
> >
> > On Thu, 29 Mar 2007, Andi Kleen wrote:
> > >
> > > Here's a patch. I don't have a system with C1E, so i only tested that
> > > the apic timer still works on a older AMD box.
> >
> > I think this looks better than what we have now, but it would look even
> > better if the core CPUID stuff was in arch/i386/kernel/cpu/amd.c, and we
> > simply had X86_FEATURE_BROKEN_C1_LAPIC etc..
>
> Please don't, this would break the interface logically.

We already have several of those. And negative is much easier.

-Andi