Re: [uml-devel] [patch 06/37] UML - Fix static linking

Blaisorblade
2007-03-31T01:21:26Z

On venerdì 30 marzo 2007, Greg KH wrote:
> -stable review patch. If anyone has any objections, please let us know.

I have one objection, the fix has a typo! This is the additional fix
(note '.note' instead of 'note'):

--- linux-2.6.git.orig/include/asm-um/common.lds.S
+++ linux-2.6.git/include/asm-um/common.lds.S
@@ -15,7 +15,7 @@
PROVIDE (_unprotected_end = .);

. = ALIGN(4096);
- .note : { *(note.*) }
+ .note : { *(.note.*) }
__start___ex_table = .;
__ex_table : { *(__ex_table) }
__stop___ex_table = .;

With this, the fix should be merged - I just re-hit this bug and rechecked
everything, now it's ok.

> ------------------
> From: Jeff Dike <jdike@addtoit.com>
>
> During a static link, ld has started putting a .note section in the
> .uml.setup.init section. This has the result that the UML setups
> begin with 32 bytes of garbage and UML crashes immediately on boot.
>
> This patch creates a specific .note section for ld to drop this stuff
> into.
>
> Signed-off-by: Jeff Dike <jdike@linux.intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> ---
> include/asm-um/common.lds.S | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/include/asm-um/common.lds.S
> +++ b/include/asm-um/common.lds.S
> @@ -15,6 +15,7 @@
> PROVIDE (_unprotected_end = .);
>
> . = ALIGN(4096);
> + .note : { *(note.*) }
> __start___ex_table = .;
> __ex_table : { *(__ex_table) }
> __stop___ex_table = .;

--
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade