From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933320AbXCaCkG (ORCPT ); Fri, 30 Mar 2007 22:40:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933334AbXCaCkG (ORCPT ); Fri, 30 Mar 2007 22:40:06 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:48867 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933320AbXCaCkE (ORCPT ); Fri, 30 Mar 2007 22:40:04 -0400 Date: Sat, 31 Mar 2007 08:17:22 +0530 From: Srivatsa Vaddagiri To: menage@google.com Cc: akpm@osdl.org, pj@sgi.com, sekharan@us.ibm.com, dev@sw.ru, xemul@sw.ru, serue@us.ibm.com, ebiederm@xmission.com, ckrm-tech@lists.sourceforge.net, linux-kernel@vger.kernel.org, containers@lists.osdl.org, mbligh@google.com, winget@google.com, rohitseth@google.com, devel@openvz.org Subject: Re: [ckrm-tech] [PATCH 7/7] containers (V7): Container interface to nsproxy subsystem Message-ID: <20070331024722.GA808@in.ibm.com> Reply-To: vatsa@in.ibm.com References: <20070212081521.808338000@menage.corp.google.com> <20070212085105.170265000@menage.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070212085105.170265000@menage.corp.google.com> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 12, 2007 at 12:15:28AM -0800, menage@google.com wrote: > +int ns_container_clone(struct task_struct *tsk) > +{ > + return container_clone(tsk, &ns_subsys); > +} This function is a no-op if ns hierarchy is not mounted at this point. This would mean that we will miss out on some directories in ns hierarchy if it happened to be mounted later. It would be nice to recreate such missing directories upon mount. However I suspect it would not be easy ..Maybe we need to scan the task list and (re-)invoke ns_container_clone() for every new tsk->nsproxy we find in the list. Alternately perhaps we could auto mount (kern_mount) ns hierarchy very early at bootup? On the flip side that would require remount support so that additional controllers (like cpuset, mem) can be bound to (non-empty) ns hierarchy after bootup. -- Regards, vatsa