From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752254AbXCaHrU (ORCPT ); Sat, 31 Mar 2007 03:47:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752223AbXCaHrU (ORCPT ); Sat, 31 Mar 2007 03:47:20 -0400 Received: from mail.chilan.com ([82.160.212.9]:54637 "EHLO mail.chilan.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbXCaHrR (ORCPT ); Sat, 31 Mar 2007 03:47:17 -0400 From: "Grzegorz Chwesewicz" To: Andi Kleen , Linus Torvalds Cc: Mark Langsdorf , Len Brown , "Morrow, William" , "Crouse, Jordan" , Thomas Gleixner , Pavel Machek , Ingo Molnar , "Eric W. Biederman" , Nick Piggin , Mingming Cao , Adrian Bunk , Andrew Morton , Linux Kernel Mailing List , Michal Piotrowski , Mariusz Kozlowski , Oliver Pinter , Sid Boyce , Nick Piggin , Jens Axboe , Thomas Renninger Subject: Re: [PATCH] i386: add command line option "local_apic_timer_c2_ok" Date: Sat, 31 Mar 2007 09:47:14 +0200 Message-Id: <20070331074239.M63498@chilan.com> In-Reply-To: <200703300005.41800.ak@suse.de> References: <200703292249.37979.ak@suse.de> <200703300005.41800.ak@suse.de> X-Mailer: OpenWebMail 2.52 20061019 X-OriginatingIP: 82.160.212.2 (ceho) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Mar 2007 00:05:39 +0200, Andi Kleen wrote > On Thursday 29 March 2007 23:16, Linus Torvalds wrote: > > > > On Thu, 29 Mar 2007, Andi Kleen wrote: > > > > > > Here's a patch. I don't have a system with C1E, so i only tested that > > > the apic timer still works on a older AMD box. > > > > I think this looks better than what we have now, but it would look even > > better if the core CPUID stuff was in arch/i386/kernel/cpu/amd.c, and we > > simply had X86_FEATURE_BROKEN_C1_LAPIC etc.. > > > > And then the apic.c code would just check > > > > if (boot_cpu_has(X86_FEATURE_BROKEN_C1_LAPIC)) > > return -1; > > > > or similar. > > Ok fair point. Here's an updated patch. I've tested this patch little bit more on my nx6325 and I've found scenario in which my box works slow. When I boot HP with connected AC (it boots fast), and then after boot I unplug AC and try to power HP off it's working very slow (powering off process take few minutes). On battery it's always booting and powering off fast. Can enybody with nx6325 confirm this ? -- Greetings - CeHo - Grzegorz Chwesewicz