From: Christoph Hellwig <hch@infradead.org>
To: Ed Lin <ed.lin@promise.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"james.Bottomley" <james.Bottomley@SteelEye.com>,
jeff <jeff@garzik.org>, promise_linux <promise_linux@promise.com>
Subject: Re: [PATCH 1/4] [SCSI]stex: fix id mapping issue
Date: Sat, 31 Mar 2007 10:26:44 +0100 [thread overview]
Message-ID: <20070331092644.GA25989@infradead.org> (raw)
In-Reply-To: <NONAMEBZNuIkdg0MZMt000005d3@nonameb.ptu.promise.com>
On Fri, Mar 30, 2007 at 03:21:33PM -0700, Ed Lin wrote:
> + if (hba->cardtype == st_shasta) {
> req->lun = lun;
> req->target = id;
> + } else if (hba->cardtype == st_yosemite){
> + req->lun = id * ST_MAX_LUN_PER_TARGET + lun;
> + req->target = 0;
> + } else {
> + /* st_vsc and st_vsc1 */
> + req->lun = 0;
> + req->target = id * ST_MAX_LUN_PER_TARGET + lun;
I don't get why you can't export id as targer and lun as lun for
the !st_shasta types. Could you explain in detail what the problem
with that approach would be?
next prev parent reply other threads:[~2007-03-31 9:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 22:21 [PATCH 1/4] [SCSI]stex: fix id mapping issue Ed Lin
2007-03-30 23:35 ` Jeff Garzik
2007-03-31 9:26 ` Christoph Hellwig [this message]
2007-03-31 14:22 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2007-04-02 17:46 Ed Lin
2007-04-02 17:59 Ed Lin
2007-04-02 23:01 Ed Lin
2007-04-04 17:31 Ed Lin
2007-04-04 17:35 ` James Bottomley
2007-04-04 18:37 Ed Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070331092644.GA25989@infradead.org \
--to=hch@infradead.org \
--cc=ed.lin@promise.com \
--cc=james.Bottomley@SteelEye.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=promise_linux@promise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox