From: Andi Kleen <ak@suse.de>
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] VMI paravirt-ops bugfix for 2.6.21
Date: Sat, 31 Mar 2007 16:35:01 +0200 [thread overview]
Message-ID: <200703311635.01776.ak@suse.de> (raw)
In-Reply-To: <460E1FC7.5030107@vmware.com>
On Saturday 31 March 2007 10:45, Zachary Amsden wrote:
> So lazy MMU mode is vulnerable to interrupts coming in and issuing
> kmap_atomic, which does not work when under lazy MMU mode. The window
> for this is small, but it means highmem kernels, especially with heavy
> network, USB, or AIO workloads are vulnerable to getting invariably
> fatal pagefaults in interrupt handlers. For now, the best fix is to
> simply disable and re-enable interrupts when entering and exiting lazy
> mode (which, btw, is already guaranteed to have preempt disabled). For
> the future, a better fix is to simply exit lazy mode when issuing
> kmap_atomic, but I do not want to touch any generic code now for 2.6.21.
I think I would prefer you touch the generic code. This new hook is ugly.
And the lazy mode is currently only used by VMI anyways, isn't it? So you shouldn't
impact anybody else
-Andi
next prev parent reply other threads:[~2007-03-31 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-31 8:45 [PATCH] VMI paravirt-ops bugfix for 2.6.21 Zachary Amsden
2007-03-31 8:02 ` Andrew Morton
2007-03-31 8:11 ` Jeremy Fitzhardinge
2007-03-31 8:11 ` Jeremy Fitzhardinge
2007-03-31 9:19 ` Zachary Amsden
2007-03-31 14:35 ` Andi Kleen [this message]
2007-04-01 7:01 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703311635.01776.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox