* submitting kernel janitorials @ 2007-03-31 13:27 Pedram M 2007-03-31 13:37 ` Cong WANG 0 siblings, 1 reply; 4+ messages in thread From: Pedram M @ 2007-03-31 13:27 UTC (permalink / raw) To: linux-kernel Do i submit that here? ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: submitting kernel janitorials 2007-03-31 13:27 submitting kernel janitorials Pedram M @ 2007-03-31 13:37 ` Cong WANG [not found] ` <9c9aa5d00703310640m6f4cf55aidc3cba706a8d3bff@mail.gmail.com> 0 siblings, 1 reply; 4+ messages in thread From: Cong WANG @ 2007-03-31 13:37 UTC (permalink / raw) To: Pedram M, linux-kernel 2007/3/31, Pedram M <pmessri@gmail.com>: > Do i submit that here? > - No. Please submit by <kernel-janitors@osdl.org>. -- So Dark The Con Of Man. ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <9c9aa5d00703310640m6f4cf55aidc3cba706a8d3bff@mail.gmail.com>]
* Re: submitting kernel janitorials [not found] ` <9c9aa5d00703310640m6f4cf55aidc3cba706a8d3bff@mail.gmail.com> @ 2007-03-31 13:52 ` Cong WANG 2007-03-31 17:02 ` Greg KH 0 siblings, 1 reply; 4+ messages in thread From: Cong WANG @ 2007-03-31 13:52 UTC (permalink / raw) To: Pedram M, linux-kernel 2007/3/31, Pedram M <pmessri@gmail.com>: > Ok thanks, > > I've sent one already, could you please double check: > > @@ -4590,7 +4590,7 @@ > printk("stli_findpcibrds()\n"); > #endif > > - while ((dev = pci_find_device(PCI_VENDOR_ID_STALLION, > + while ((dev = pci_get_device(PCI_VENDOR_ID_STALLION, > PCI_DEVICE_ID_ECRA, dev))) { > if ((rc = stli_initpcibrd(BRD_ECPPCI, dev))) > return(rc); > > > That as an example for file: > > drivers/char/istallion.c > > > Thanks, > Pedram Why did you delete the list? Please don't do that. In fact, I am a newbie too. I know pci_find* functions are deprecated and gcc will warn that. And I think we should replace them. You can try to make patches for them and submit them to Greg. (Greg, is that OK?) -- So Dark The Con Of Man. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: submitting kernel janitorials 2007-03-31 13:52 ` Cong WANG @ 2007-03-31 17:02 ` Greg KH 0 siblings, 0 replies; 4+ messages in thread From: Greg KH @ 2007-03-31 17:02 UTC (permalink / raw) To: Cong WANG; +Cc: Pedram M, linux-kernel On Sat, Mar 31, 2007 at 09:52:30PM +0800, Cong WANG wrote: > 2007/3/31, Pedram M <pmessri@gmail.com>: > >Ok thanks, > > > >I've sent one already, could you please double check: > > > >@@ -4590,7 +4590,7 @@ > > printk("stli_findpcibrds()\n"); > > #endif > > > >- while ((dev = pci_find_device(PCI_VENDOR_ID_STALLION, > >+ while ((dev = pci_get_device(PCI_VENDOR_ID_STALLION, > > PCI_DEVICE_ID_ECRA, dev))) { > > if ((rc = stli_initpcibrd(BRD_ECPPCI, dev))) > > return(rc); > > > > > >That as an example for file: > > > >drivers/char/istallion.c > > > > > >Thanks, > >Pedram > > Why did you delete the list? Please don't do that. > > In fact, I am a newbie too. I know pci_find* functions are deprecated > and gcc will warn that. And I think we should replace them. You can > try to make patches for them and submit them to Greg. (Greg, is that > OK?) You can cc: me, so I will review them, but the patch needs to go through the specific driver maintainer. And PLEASE NOTE, this kind of conversion is not a simple search-and-replace type task, you need to be aware of the device reference count issues with the pci_get_device() call. Please read the documentation for the function for details. thanks, greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-03-31 17:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-31 13:27 submitting kernel janitorials Pedram M
2007-03-31 13:37 ` Cong WANG
[not found] ` <9c9aa5d00703310640m6f4cf55aidc3cba706a8d3bff@mail.gmail.com>
2007-03-31 13:52 ` Cong WANG
2007-03-31 17:02 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox