Re: [PATCH] i386: add command line option "local_apic_timer_c2_ok"

Grzegorz Chwesewicz
2007-03-30T21:06:07Z

On Fri, 30 Mar 2007 00:05:39 +0200, Andi Kleen wrote
> On Thursday 29 March 2007 23:16, Linus Torvalds wrote:
> >
> > On Thu, 29 Mar 2007, Andi Kleen wrote:
> > >
> > > Here's a patch. I don't have a system with C1E, so i only tested that
> > > the apic timer still works on a older AMD box.
> >
> > I think this looks better than what we have now, but it would look even
> > better if the core CPUID stuff was in arch/i386/kernel/cpu/amd.c, and we
> > simply had X86_FEATURE_BROKEN_C1_LAPIC etc..
> >
> > And then the apic.c code would just check
> >
> > if (boot_cpu_has(X86_FEATURE_BROKEN_C1_LAPIC))
> > return -1;
> >
> > or similar.
>
> Ok fair point. Here's an updated patch.

This patch also works. If You want bootlog or output of /proc/interrupts I can
post it.

--
Greetings - CeHo - Grzegorz Chwesewicz