From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <clameter@sgi.com>, Sam Ravnborg <sam@ravnborg.org>
Cc: "Paolo 'Blaisorblade' Giarrusso" <blaisorblade@yahoo.it>,
linux-kernel@vger.kernel.org,
Christoph Lameter <clameter@engr.sgi.com>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 3/3] slab: avoid __initdata warning (may be a bogus one)
Date: Sun, 1 Apr 2007 00:30:59 -0700 [thread overview]
Message-ID: <20070401003059.b830fb85.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0704010011390.23774@schroedinger.engr.sgi.com>
On Sun, 1 Apr 2007 00:15:06 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
> On Sat, 31 Mar 2007, Andrew Morton wrote:
>
> > Yes, I think this is a flase positive - we'll never touch initkmem_list3[]
> > after free_initmem() because of the transitions of g_cpucache_up.
>
> Correct.
>
> > (In which case set_up_list3s() shoud be __init, too?)
>
> Correct. Its only called during slab bootstrap.
>
> > Christoph, I think you looked at this previously?
>
> If you change set_up_list3s to __init then we have the same issue with
> setup_cpu_cache right?
yup.
I wonder if there's a general way in which we can suppress such false
positives. Say, create a new section called, umm, __nowarn and
__nowarndata and then we can tag functions or data with those tags tag and teach
the checker tools to ignore them?
prev parent reply other threads:[~2007-04-01 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 23:07 [PATCH 0/3] mm-only patches Paolo 'Blaisorblade' Giarrusso
2007-03-30 23:08 ` [PATCH 1/3] utrace - uml: make UML compile with utrace enabled Paolo 'Blaisorblade' Giarrusso
2007-04-04 21:00 ` Roland McGrath
2007-03-30 23:08 ` [PATCH 2/3] sys_futex64-allows-64bit-futexes-workaround for uml Paolo 'Blaisorblade' Giarrusso
2007-03-30 23:08 ` [PATCH 3/3] slab: avoid __initdata warning (may be a bogus one) Paolo 'Blaisorblade' Giarrusso
2007-04-01 5:28 ` Andrew Morton
2007-04-01 7:15 ` Christoph Lameter
2007-04-01 7:30 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070401003059.b830fb85.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=blaisorblade@yahoo.it \
--cc=clameter@engr.sgi.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox