Re: [PATCH] hid: add two led codes to hid input mapping

[Dmitry Torokhov <dtor@insightbb.com>]

On Sunday 01 April 2007 05:01, Jiri Kosina wrote:
> On Sat, 31 Mar 2007, Dan Engel wrote:
> 
> > This patch is really being offered because it's what's needed to make the operation
> > of the Belkin Flip USB KVM switch avaiable to user-space programs through the HID input
> > event interface. The Belkin Flip KVM overloads LED usages to give software control
> > over the device, providing options to flip either audio, video or both. However,
> > without an input mapping to the Off-hook and Speaker LED usages, this functionality
> > isn't available.
> 
> Dmitry, would adding these two LED_ constants to input.h be OK by you? 
> (the coresponding usages are defined in HUT 1.12 on page 62).
> 

No, I do not want to add any more LED constants to input. In fact I think
that adding constants beyond keyboard indicators was a mistake. We have 
led subsystem that provides interface to control arbitrary leds and we
should use it.

-- 
Dmitry