From: Jens Axboe <jens.axboe@oracle.com>
To: Rene Herman <rene.herman@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Al Viro <viro@ftp.linux.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: mcdx -- do_request(): non-read command to cd!!
Date: Mon, 2 Apr 2007 08:42:45 +0200 [thread overview]
Message-ID: <20070402064245.GC11996@kernel.dk> (raw)
In-Reply-To: <4610481D.8000102@gmail.com>
On Mon, Apr 02 2007, Rene Herman wrote:
> On 04/01/2007 12:06 PM, Pekka Enberg wrote:
>
> >Looks like mcdx_xfer is sleeping while holding q->queue_lock. The
> >attached (untested) patch should fix it.
>
> This (including your followup) does indeed avoid the traces in the
> kernel log, but unfortunately, the driver seems to need a bit more.
I took a quick look at the driver, and it's pretty much utter crap so I
would not expect much. If you want to use it, make sure you at least
disable any form of SMP and preempt.
> Last time Al Viro suggested ripping them out, I slightly objected:
>
> http://lkml.org/lkml/2004/5/2/123
>
> but well, although I like playing with this stuff, I still don't know
> the first thing about the block layer and given the shape these things
> are in...
The questionable quality of the ancient CDROM drivers itself makes it
appealing to just dump it.
--
Jens Axboe
next prev parent reply other threads:[~2007-04-02 6:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 21:21 mcdx -- do_request(): non-read command to cd!! Rene Herman
2007-03-31 6:47 ` Jens Axboe
2007-03-31 18:23 ` Rene Herman
2007-04-01 10:06 ` Pekka Enberg
2007-04-01 10:16 ` Pekka Enberg
2007-04-02 0:02 ` Rene Herman
2007-04-02 0:07 ` Rene Herman
2007-04-02 6:50 ` Pekka J Enberg
2007-04-02 7:10 ` Jens Axboe
2007-04-02 7:37 ` Pekka J Enberg
2007-04-02 8:55 ` Pekka J Enberg
2007-04-02 9:32 ` Boaz Harrosh
2007-04-02 9:42 ` Pekka J Enberg
2007-04-02 9:42 ` Jens Axboe
2007-04-02 21:02 ` Rene Herman
2007-04-02 15:18 ` Rene Herman
2007-04-02 15:45 ` Rene Herman
[not found] ` <Pine.LNX.4.64.0704021837480.6518@sbz-30.cs.Helsinki.FI>
[not found] ` <46112650.8080208@gmail.com>
[not found] ` <Pine.LNX.4.64.0704021906040.7500@sbz-30.cs.Helsinki.FI>
[not found] ` <461165FD.2010508@gmail.com>
[not found] ` <Pine.LNX.4.64.0704030908420.20080@sbz-30.cs.Helsinki.FI>
[not found] ` <Pine.LNX.4.64.0704030956330.20741@sbz-30.cs.Helsinki.FI>
2007-04-03 14:26 ` Rene Herman
2007-04-03 17:37 ` Pekka J Enberg
[not found] ` <461256C1.4020906@gmail.com>
2007-04-03 14:33 ` Pekka J Enberg
2007-04-03 17:31 ` Pekka J Enberg
2007-04-03 18:14 ` Rene Herman
2007-04-03 18:32 ` Pekka J Enberg
2007-04-04 2:10 ` Rene Herman
2007-04-04 6:30 ` Pekka Enberg
2007-04-04 6:19 ` Jens Axboe
2007-04-02 15:39 ` Rene Herman
2007-04-02 6:42 ` Jens Axboe [this message]
2007-04-02 7:07 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070402064245.GC11996@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=rene.herman@gmail.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox