Re: mcdx -- do_request(): non-read command to cd!!

Jens Axboe
2007-04-02T06:43:59Z

On Mon, Apr 02 2007, Rene Herman wrote:
> On 04/01/2007 12:06 PM, Pekka Enberg wrote:
>
> >Looks like mcdx_xfer is sleeping while holding q->queue_lock. The
> >attached (untested) patch should fix it.
>
> This (including your followup) does indeed avoid the traces in the
> kernel log, but unfortunately, the driver seems to need a bit more.

I took a quick look at the driver, and it's pretty much utter crap so I
would not expect much. If you want to use it, make sure you at least
disable any form of SMP and preempt.

> Last time Al Viro suggested ripping them out, I slightly objected:
>
> http://lkml.org/lkml/2004/5/2/123
>
> but well, although I like playing with this stuff, I still don't know
> the first thing about the block layer and given the shape these things
> are in...

The questionable quality of the ancient CDROM drivers itself makes it
appealing to just dump it.

--
Jens Axboe