From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: driver core: do not wait unnecessarily in driver_unregister()
Date: Mon, 2 Apr 2007 00:28:58 -0700 [thread overview]
Message-ID: <20070402072858.GA19241@kroah.com> (raw)
In-Reply-To: <200704012059.l31Kx2R5005810@hera.kernel.org>
On Sun, Apr 01, 2007 at 08:59:02PM +0000, Linux Kernel Mailing List wrote:
> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f5ef2abcbeb5b0be23f7cc610a024b2406e3d8e6
> Commit: f5ef2abcbeb5b0be23f7cc610a024b2406e3d8e6
> Parent: 755948cfca16c71b16e8ff4a9d4dd31b1c0bf923
> Author: Linus Torvalds <torvalds@woody.linux-foundation.org>
> AuthorDate: Sun Apr 1 10:54:13 2007 -0700
> Committer: Linus Torvalds <torvalds@woody.linux-foundation.org>
> CommitDate: Sun Apr 1 10:54:13 2007 -0700
>
> driver core: do not wait unnecessarily in driver_unregister()
>
> Ingo reported that built-in drivers suffered bootup hangs with certain
> driver unregistry sequences, due to sysfs breakage.
>
> Do the minimal fix for v2.6.21: only wait if the driver is a module.
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Linus, please revert this patch. It merely papers over the fact that
there is a reference count still around that never gets released. Kay's
patch that Andrew just forwarded to you fixes the real problem, which
other people had noticed and this patch does not fix.
thanks,
greg k-h
parent reply other threads:[~2007-04-02 7:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200704012059.l31Kx2R5005810@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070402072858.GA19241@kroah.com \
--to=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox