* Re: driver core: do not wait unnecessarily in driver_unregister()
[not found] <200704012059.l31Kx2R5005810@hera.kernel.org>
@ 2007-04-02 7:28 ` Greg KH
0 siblings, 0 replies; only message in thread
From: Greg KH @ 2007-04-02 7:28 UTC (permalink / raw)
To: Linus Torvalds, Ingo Molnar; +Cc: Linux Kernel Mailing List, Kay Sievers
On Sun, Apr 01, 2007 at 08:59:02PM +0000, Linux Kernel Mailing List wrote:
> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f5ef2abcbeb5b0be23f7cc610a024b2406e3d8e6
> Commit: f5ef2abcbeb5b0be23f7cc610a024b2406e3d8e6
> Parent: 755948cfca16c71b16e8ff4a9d4dd31b1c0bf923
> Author: Linus Torvalds <torvalds@woody.linux-foundation.org>
> AuthorDate: Sun Apr 1 10:54:13 2007 -0700
> Committer: Linus Torvalds <torvalds@woody.linux-foundation.org>
> CommitDate: Sun Apr 1 10:54:13 2007 -0700
>
> driver core: do not wait unnecessarily in driver_unregister()
>
> Ingo reported that built-in drivers suffered bootup hangs with certain
> driver unregistry sequences, due to sysfs breakage.
>
> Do the minimal fix for v2.6.21: only wait if the driver is a module.
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Linus, please revert this patch. It merely papers over the fact that
there is a reference count still around that never gets released. Kay's
patch that Andrew just forwarded to you fixes the real problem, which
other people had noticed and this patch does not fix.
thanks,
greg k-h
^ permalink raw reply [flat|nested] only message in thread