Re: [PATCH 11/16] samba-eintr-fix.diff

Dave Jones
2007-04-01T19:43:06Z

On Sun, Apr 01, 2007 at 09:28:03PM +0200, Jan Engelhardt wrote:
>
> On Apr 1 2007 15:09, Dave Jones wrote:
> >On Sun, Apr 01, 2007 at 08:16:22PM +0200, Jan Engelhardt wrote:
>
> > > From: Dave Jones
> > > Already posted at http://lkml.org/lkml/2005/7/7/255
> >
> >I had to stop and think if this was an April 1st :)
>
> Read the mail entitled "[PATCH 0/16] Assorted patches".

That's what happens when you read inbox before mailing list folders :)

> >As to whether the patch is worthwhile/correct..
> >I really don't know. I posted it back then in the hopes
> >that someone smbfs-savvy would pop up and review it.
> >As you can see from the archive, no-one did.
>
> It seems to have been resent once, 7 days after you:
> http://lkml.org/lkml/2005/7/15/231

Hmm, with no changelog. I wonder if JA was hitting that bug
and independantly came up with that patch, or was just
resubmitting on my behalf.

> At that time, I had experienced strange copy failures ("No such file or
> directory") while the directory being copied was not modified. With the
> patch, I at least got EINTR instead of ENOENT, which I think made cp
> think once more to retry.

I suppose we could throw it in -mm and see if anyone screams. Andrew?

Dave

--