Re: [PATCH 13/16] show-pipesize-in-stat.diff

Jan Engelhardt
2007-04-17T08:06:58Z

Hi,

On Wed, 04 Apr 2007 07:03:55 +0200, Eric Dumazet wrote:
>find net | xargs grep -n SIOCINQ
>I suspect you will find unix_ioctl() in net/unix/af_unix.c ?
>BTW, my patch only worked for pipes, not fifos. Ie pipe(), not
>open("/some/fifo.p", ...)

Thanks for your patch. There is a question however; why don't you do
stat->size = pipe_size(inode);
in generic_fill_attr (perhaps wrapped into an if(S_ISFIFO))?

Regards,
Jan
--