Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

Ingo Molnar
2007-04-04T20:37:44Z

* Daniel Walker <dwalker@mvista.com> wrote:

> The struct clocksource .list field is now required to be initialized
> before calling clocksource_register().
>
> This is a prerequisite for simplifying the clocksource registration
> process.

why? This patch only pushes some unnecessary code into the clocksource
drivers:

+ .list = LIST_HEAD_INIT(clocksource_avr32.list),

NACK unless you can give an explanation of why this is unavoidable. A
NULL initializer is just as good as an initialized list entry. (in fact
it's slightly better because it's in the kernel's BSS)

Ingo