Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

Daniel Walker
2007-04-04T20:45:38Z

On Wed, 2007-04-04 at 22:36 +0200, Ingo Molnar wrote:
> * Daniel Walker <dwalker@mvista.com> wrote:
>
> > The struct clocksource .list field is now required to be initialized
> > before calling clocksource_register().
> >
> > This is a prerequisite for simplifying the clocksource registration
> > process.
>
> why? This patch only pushes some unnecessary code into the clocksource
> drivers:
>
> + .list = LIST_HEAD_INIT(clocksource_avr32.list),
>
> NACK unless you can give an explanation of why this is unavoidable. A
> NULL initializer is just as good as an initialized list entry. (in fact
> it's slightly better because it's in the kernel's BSS)

This is only 1 of 9 patches . The 9th patch requires the .list value to
be initialized .. The description change above was suppose to make that
clearer .. By forcing the .list value to be initialized we can simplify
the clocksource registration .

Daniel