Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

Daniel Walker
2007-04-05T00:35:29Z

On Wed, 2007-04-04 at 17:20 -0700, Jeremy Fitzhardinge wrote:
> Daniel Walker wrote:
> > Setting CLOCK_SOURCE_IS_CONTINUOUS is largely administration , do you
> > know what that flag means?
> >
>
> Sure, but at least it has something to do with clocks and time.
>
> > list values and list initialization are hardly internal details , they
> > are commonly used all over the kernel.
> >
>
> The fact that a list is used to string together clocksource structures
> is an internal detail of the clock subsystem. It's annoying that there
> has to be a list head in the clocksource structure, but at least as a
> clocksource implementer I can ignore it, and if it ever gets changed to
> something else I can keep ignoring it. Your change makes it something
> that gets pointlessly replicated all over the kernel.

It's already been discussed in the past, but the clocksource structure
is already very simple.. Adding a list initializer doesn't change
anything..

Daniel