Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

Jeremy Fitzhardinge
2007-04-05T00:21:13Z

Daniel Walker wrote:
> Setting CLOCK_SOURCE_IS_CONTINUOUS is largely administration , do you
> know what that flag means?
>

Sure, but at least it has something to do with clocks and time.

> list values and list initialization are hardly internal details , they
> are commonly used all over the kernel.
>

The fact that a list is used to string together clocksource structures
is an internal detail of the clock subsystem. It's annoying that there
has to be a list head in the clocksource structure, but at least as a
clocksource implementer I can ignore it, and if it ever gets changed to
something else I can keep ignoring it. Your change makes it something
that gets pointlessly replicated all over the kernel.

The real point is that it seems this change just adds work and cruft,
but for no benefit. Your comment is that it "simplifies the
registration process". Why does it need to be simpler? How is it
simpler? From a clocksource implementers perspective, the registration
is already pretty simple; how does it get simpler? It looks less simple
to me, because now there's another failure-mode (a BUG if I forget to
initialize the list).

J