* [KJ][PATCH]ROUND_UP macro cleanup in drivers/net/ppp_generic.c
@ 2007-04-04 17:49 Milind Arun Choudhary
2007-04-09 18:28 ` Paul Mackerras
0 siblings, 1 reply; 2+ messages in thread
From: Milind Arun Choudhary @ 2007-04-04 17:49 UTC (permalink / raw)
To: kernel-janitors; +Cc: linux-kernel, akpm, linux-ppp, paulus
ROUND_UP macro cleanup use DIV_ROUND_UP
Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
---
ppp_generic.c | 4 +---
1 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c
index ef58e41..4b302f3 100644
--- a/drivers/net/ppp_generic.c
+++ b/drivers/net/ppp_generic.c
@@ -88,8 +88,6 @@ struct ppp_file {
#define PF_TO_PPP(pf) PF_TO_X(pf, struct ppp)
#define PF_TO_CHANNEL(pf) PF_TO_X(pf, struct channel)
-#define ROUNDUP(n, x) (((n) + (x) - 1) / (x))
-
/*
* Data structure describing one ppp unit.
* A ppp unit corresponds to a ppp network interface device
@@ -1297,7 +1295,7 @@ static int ppp_mp_explode(struct ppp *ppp, struct sk_buff *skb)
*/
fragsize = len;
if (nfree > 1)
- fragsize = ROUNDUP(fragsize, nfree);
+ fragsize = DIV_ROUND_UP(fragsize, nfree);
/* nbigger channels get fragsize bytes, the rest get fragsize-1,
except if nbigger==0, then they all get fragsize. */
nbigger = len % nfree;
---
Milind Arun Choudhary
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [KJ][PATCH]ROUND_UP macro cleanup in drivers/net/ppp_generic.c
2007-04-04 17:49 [KJ][PATCH]ROUND_UP macro cleanup in drivers/net/ppp_generic.c Milind Arun Choudhary
@ 2007-04-09 18:28 ` Paul Mackerras
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mackerras @ 2007-04-09 18:28 UTC (permalink / raw)
To: Milind Arun Choudhary; +Cc: kernel-janitors, linux-kernel, akpm, linux-ppp
Milind Arun Choudhary writes:
> ROUND_UP macro cleanup use DIV_ROUND_UP
>
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
Acked-by: Paul Mackerras <paulus@samba.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-09 21:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-04 17:49 [KJ][PATCH]ROUND_UP macro cleanup in drivers/net/ppp_generic.c Milind Arun Choudhary
2007-04-09 18:28 ` Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox