From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750827AbXDDUho (ORCPT ); Wed, 4 Apr 2007 16:37:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750833AbXDDUho (ORCPT ); Wed, 4 Apr 2007 16:37:44 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:33338 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbXDDUhn (ORCPT ); Wed, 4 Apr 2007 16:37:43 -0400 Date: Wed, 4 Apr 2007 22:36:47 +0200 From: Ingo Molnar To: Daniel Walker Cc: Andrew Morton , tglx@linutronix.de, johnstul@us.ibm.com, LKML , heiko.carstens@de.ibm.com Subject: Re: + clocksource-driver-initialize-list-value.patch added to -mm tree Message-ID: <20070404203647.GA12563@elte.hu> References: <200704010523.l315NXJP004063@shell0.pdx.osdl.net> <1175417035.28263.42.camel@localhost.localdomain> <1175704712.15973.35.camel@imap.mvista.com> <20070404125853.1cf9b7b7.akpm@linux-foundation.org> <1175717425.15973.61.camel@imap.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1175717425.15973.61.camel@imap.mvista.com> User-Agent: Mutt/1.4.2.2i X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.1.7 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Daniel Walker wrote: > The struct clocksource .list field is now required to be initialized > before calling clocksource_register(). > > This is a prerequisite for simplifying the clocksource registration > process. why? This patch only pushes some unnecessary code into the clocksource drivers: + .list = LIST_HEAD_INIT(clocksource_avr32.list), NACK unless you can give an explanation of why this is unavoidable. A NULL initializer is just as good as an initialized list entry. (in fact it's slightly better because it's in the kernel's BSS) Ingo