Re: [PATCH 1/4] x86_64: Switch to SPARSE_VIRTUAL

Christoph Lameter
2007-04-02T16:18:18Z

On Sun, 1 Apr 2007, Andi Kleen wrote:

> Or do you have overlaps with other memory (I think you have)

We may get into a case where some page structs are physically located
on other nodes if there are no holes between nodes. This would be
particularly significant for 64MB node sizes using numa emulation.
But there it really does not matter where the real memory is located.
(this is really inherent in sparsemems way of mapping memory).

> In that case you have to handle the overlap in change_page_attr()

Why would we use change_page_attr on page structs? I can see that the
pages themselves should be subject to change_page_attr but why the
page_structs? I think the system would panic if one would set page structs
to read only.