From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
tglx@linutronix.de, johnstul@us.ibm.com,
LKML <linux-kernel@vger.kernel.org>,
heiko.carstens@de.ibm.com
Subject: Re: + clocksource-driver-initialize-list-value.patch added to -mm tree
Date: Wed, 4 Apr 2007 23:34:04 +0200 [thread overview]
Message-ID: <20070404213404.GA21742@elte.hu> (raw)
In-Reply-To: <1175722246.15973.78.camel@imap.mvista.com>
* Daniel Walker <dwalker@mvista.com> wrote:
> > but why do you call that a simplification? Remove 5 lines of code
> > from the generic code, by adding +1 line to every clocksource
> > driver, totalling to like +20 lines at the moment?
>
> I guess I don't look at it in terms of lines .. Why do you think
> reciting a line count diminishes the "simplification" claim? The 20+
> lines that I added to each clocksource don't have a size or runtime
> effect ..
but they have a robustness and maintainability effect. Key is to keep
drivers _simple_ and hard to mess up. If it's 5 extra lines of code to
simplify a driver then we just do it. This is maintainance 101.
i cannot believe you are still arguing this. I explained this to you
many weeks ago!
Ingo
next prev parent reply other threads:[~2007-04-04 21:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200704010523.l315NXJP004063@shell0.pdx.osdl.net>
2007-04-01 8:43 ` + clocksource-driver-initialize-list-value.patch added to -mm tree Thomas Gleixner
2007-04-04 16:38 ` Daniel Walker
2007-04-04 19:58 ` Andrew Morton
2007-04-04 20:10 ` Daniel Walker
2007-04-04 20:36 ` Ingo Molnar
2007-04-04 20:44 ` Daniel Walker
2007-04-04 21:15 ` Ingo Molnar
2007-04-04 21:30 ` Daniel Walker
2007-04-04 21:34 ` Ingo Molnar [this message]
2007-04-04 21:59 ` Daniel Walker
2007-04-04 23:48 ` Jeremy Fitzhardinge
2007-04-05 0:00 ` Daniel Walker
2007-04-05 0:20 ` Jeremy Fitzhardinge
2007-04-05 0:34 ` Daniel Walker
2007-04-05 6:02 ` Thomas Gleixner
2007-04-05 7:51 ` Ingo Molnar
2007-04-05 11:35 ` Daniel Walker
2007-04-04 20:48 ` Andrew Morton
2007-04-04 21:47 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070404213404.GA21742@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=heiko.carstens@de.ibm.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox