[PATCH 2.6.21-rc5] kernel/time.c: add missing symbol exports

[PATCH 2.6.21-rc5] kernel/time.c: add missing symbol exports

[Thomas Bittermann]

From: Thomas Bittermann <t.bittermann@online.de>

This patch adds 2 missing symbol exports:

jiffies_to_timeval
timeval_to_jiffies

Signed-off-by: Thomas Bittermann <t.bittermann@online.de>
---
 kernel/time.c |    2 ++
 1 file changed, 2 insertions(+)
Index: linux-2.6.21-rc5.fix/kernel/time.c
===================================================================
--- linux-2.6.21-rc5.orig/kernel/time.c 2007-04-04 21:39:02.000000000 +0200
+++ linux-2.6.21-rc5.fix/kernel/time.c  2007-04-04 21:39:14.000000000 +0200
@@ -635,6 +635,7 @@ timeval_to_jiffies(const struct timeval
                (((u64)usec * USEC_CONVERSION + USEC_ROUND) >>
                 (USEC_JIFFIE_SC - SEC_JIFFIE_SC))) >> SEC_JIFFIE_SC;
 }
+EXPORT_SYMBOL(timeval_to_jiffies);

 void jiffies_to_timeval(const unsigned long jiffies, struct timeval *value)
 {
@@ -649,6 +650,7 @@ void jiffies_to_timeval(const unsigned l
        tv_usec /= NSEC_PER_USEC;
        value->tv_usec = tv_usec;
 }
+EXPORT_SYMBOL(jiffies_to_timeval);

 /*
  * Convert jiffies/jiffies_64 to clock_t and back.

Re: [PATCH 2.6.21-rc5] kernel/time.c: add missing symbol exports

[Andrew Morton]

On Wed, 04 Apr 2007 22:20:54 +0200
Thomas Bittermann <t.bittermann@online.de> wrote:

> This patch adds 2 missing symbol exports:
> 
> jiffies_to_timeval
> timeval_to_jiffies

I don't see any in-tree code which needs these symbols?

The exports might make sense from a consistency POV, but I'd be interested
in knowing what motivated this change?

Re: [PATCH 2.6.21-rc5] kernel/time.c: add missing symbol exports

[Thomas Bittermann]

Andrew Morton schrieb:
> On Wed, 04 Apr 2007 22:20:54 +0200
> Thomas Bittermann <t.bittermann@online.de> wrote:
> 
>> This patch adds 2 missing symbol exports:
>>
>> jiffies_to_timeval
>> timeval_to_jiffies
> 
> I don't see any in-tree code which needs these symbols?
> 
> The exports might make sense from a consistency POV, but I'd be interested
> in knowing what motivated this change?
I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
(http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). dm-raid4-5.c uses
jiffies_to_timeval() ...

Thanks for your quick response.

Thomas

Re: [PATCH 2.6.21-rc5] kernel/time.c: add missing symbol exports

[Andrew Morton]

On Wed, 04 Apr 2007 23:13:11 +0200
Thomas Bittermann <t.bittermann@online.de> wrote:

> Andrew Morton schrieb:
> > On Wed, 04 Apr 2007 22:20:54 +0200
> > Thomas Bittermann <t.bittermann@online.de> wrote:
> > 
> >> This patch adds 2 missing symbol exports:
> >>
> >> jiffies_to_timeval
> >> timeval_to_jiffies
> > 
> > I don't see any in-tree code which needs these symbols?
> > 
> > The exports might make sense from a consistency POV, but I'd be interested
> > in knowing what motivated this change?
> I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
> (http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). dm-raid4-5.c uses
> jiffies_to_timeval() ...
> 

Fair enough.

John/Ingo/Thomas: have you any problems with exporting the above to modules
(with EXPORT_SYMBOL)?

Re: [PATCH 2.6.21-rc5] kernel/time.c: add missing symbol exports

[Ingo Molnar]

* Andrew Morton <akpm@linux-foundation.org> wrote:

> > I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5 
> > (http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). 
> > dm-raid4-5.c uses jiffies_to_timeval() ...
> 
> Fair enough.
> 
> John/Ingo/Thomas: have you any problems with exporting the above to 
> modules (with EXPORT_SYMBOL)?

i have no problems with that. I think it was even a traditional api, but 
inlined.

	Ingo

Re: [PATCH 2.6.21-rc5] kernel/time.c: add missing symbol exports

[john stultz]

On Wed, 2007-04-04 at 14:30 -0700, Andrew Morton wrote:
> On Wed, 04 Apr 2007 23:13:11 +0200
> Thomas Bittermann <t.bittermann@online.de> wrote:
> 
> > Andrew Morton schrieb:
> > > On Wed, 04 Apr 2007 22:20:54 +0200
> > > Thomas Bittermann <t.bittermann@online.de> wrote:
> > > 
> > >> This patch adds 2 missing symbol exports:
> > >>
> > >> jiffies_to_timeval
> > >> timeval_to_jiffies
> > > 
> > > I don't see any in-tree code which needs these symbols?
> > > 
> > > The exports might make sense from a consistency POV, but I'd be interested
> > > in knowing what motivated this change?
> > I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
> > (http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). dm-raid4-5.c uses
> > jiffies_to_timeval() ...
> > 
> 
> Fair enough.
> 
> John/Ingo/Thomas: have you any problems with exporting the above to modules
> (with EXPORT_SYMBOL)?

As long as jiffies and HZ is exported, I don't see why not.

thanks
-john

Re: [PATCH 2.6.21-rc5] kernel/time.c: add missing symbol exports

[Thomas Gleixner]

On Wed, 2007-04-04 at 14:30 -0700, Andrew Morton wrote:
> On Wed, 04 Apr 2007 23:13:11 +0200
> Thomas Bittermann <t.bittermann@online.de> wrote:
> 
> > Andrew Morton schrieb:
> > > On Wed, 04 Apr 2007 22:20:54 +0200
> > > Thomas Bittermann <t.bittermann@online.de> wrote:
> > > 
> > >> This patch adds 2 missing symbol exports:
> > >>
> > >> jiffies_to_timeval
> > >> timeval_to_jiffies
> > > 
> > > I don't see any in-tree code which needs these symbols?
> > > 
> > > The exports might make sense from a consistency POV, but I'd be interested
> > > in knowing what motivated this change?
> > I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5
> > (http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). dm-raid4-5.c uses
> > jiffies_to_timeval() ...
> > 
> 
> Fair enough.
> 
> John/Ingo/Thomas: have you any problems with exporting the above to modules
> (with EXPORT_SYMBOL)?

Fine with me.

	tglx

Re: [PATCH 2.6.21-rc5] kernel/time.c: add missing symbol exports

[Thomas Bittermann]

Ingo Molnar schrieb:
> * Andrew Morton <akpm@linux-foundation.org> wrote:
> 
>>> I'm working on a Fedora 7 LiveCD which integrates dm-raid4-5 
>>> (http://people.redhat.com/~heinzm/sw/dm/dm-raid45/readme). 
>>> dm-raid4-5.c uses jiffies_to_timeval() ...
>> Fair enough.
>>
>> John/Ingo/Thomas: have you any problems with exporting the above to 
>> modules (with EXPORT_SYMBOL)?
> 
> i have no problems with that. I think it was even a traditional api, but 
> inlined.
Yes it was inlined before and got lost somewhere between 2.6.20 and 2.6.21-rcX - don't know
exactly which one it was (see http://lkml.org/lkml/2007/1/23/198)

Cheers & thanks
Thomas