public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Mike Miller <mike.miller@hp.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Perverting cciss
Date: Thu, 5 Apr 2007 11:03:26 +0100	[thread overview]
Message-ID: <20070405100326.GA19092@infradead.org> (raw)
In-Reply-To: <4614C82E.1020100@suse.de>

On Thu, Apr 05, 2007 at 11:58:06AM +0200, Hannes Reinecke wrote:
> Hi All,
> 
> this patch adds the SG_IO ioctl to the cciss driver.
> As the driver is capable of sending SCSI CDBs to the controller there is
> no reason why we shouldn't exploit it.
> This way we get to use all the nice sg_utils for the cciss driver.
> And a persistent device name for free.

Instead of adding yet another implementation of SG_IO please implement
support for REQ_TYPE_BLOCK_PC requests and add all the nice block layer
passthrough ioctls to it.

> Makes one wonder why this one is not implemented as a SCSI driver in the
> first place.

It probably should have been a scsi driver, but it's far too late now.


  reply	other threads:[~2007-04-05 10:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-05  9:58 [PATCH] Perverting cciss Hannes Reinecke
2007-04-05 10:03 ` Christoph Hellwig [this message]
2007-04-05 14:09   ` James Bottomley
2007-04-05 14:37     ` Miller, Mike (OS Dev)
  -- strict thread matches above, loose matches on Subject: below --
2007-04-06 17:07 Stephen Cameron
2007-04-08 10:19 ` Christoph Hellwig
2007-04-08 16:26   ` Stephen Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070405100326.GA19092@infradead.org \
    --to=hch@infradead.org \
    --cc=hare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mike.miller@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox