Re: What protects cpu_tlbstate?

[Andi Kleen <ak@suse.de>]

On Thursday 05 April 2007 21:44:10 Jeremy Fitzhardinge wrote:
> Hi,
> 
> What protects the cpu_tlbstate?  I see in i386/kernel/smp.c that its
> always used in a non-preemptable area, but what prevents races with
> interrupts?  For example, what prevents leave_mm() called via the
> flush_tlb_all IPI from racing with, say, enter_lazy_tlb?  Couldn't a
> race leave cpu_tlbstate in an inconsistent state?
> 
> Or does it simply not matter?  But if that were true, it seems to me
> that there should be at least some barriers or something to make sure
> the final state is consistent.

The interrupts can only happen when the other CPU is already lazy
and enter_lazy_tlb would be a nop then.  The flushers itself are
synchronized by the page_table_lock or the mm semaphore.

Against switch_mm it tries to protect with ordering.

wmb()s are not needed on x86 (ok minus errata on ppro and
VIA magic mode but which is UP only). That would leave some rmb()s,
but I don't see any place they would be needed. 

-Andi