From: Ingo Molnar <mingo@elte.hu>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>, Robin Holt <holt@sgi.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Chris Snook <csnook@redhat.com>,
linux-kernel@vger.kernel.org,
Jack Steiner <steiner@americas.sgi.com>
Subject: Re: [patch] sched: get rid of p->children use in show_task()
Date: Fri, 6 Apr 2007 21:22:59 +0200 [thread overview]
Message-ID: <20070406192259.GA18722@elte.hu> (raw)
In-Reply-To: <20070406191806.GA15291@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> > > i.e. a to-be-reaped task will still be on the main list _too_. The
> > > main list is for all the PID semantics rules. The reap-list is
> > > just for wait4() processing. The two would be completely separate.
> >
> > And what pray tell except for heuristics is the list of children
> > used for?
>
> yeah - by all means get rid of it, but first separate the data
> structures along uses. Then all the 'why should we iterate two lists
> in sequence' questions vanish.
and this way we get the best change as well: not only will kthreads be
removed from that list, but all other tasks in the system too. I bet
this will speed up wait4() _enormously_, on server workloads that
involve many tasks.
Ingo
next prev parent reply other threads:[~2007-04-06 19:23 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 19:51 init's children list is long and slows reaping children Robin Holt
2007-04-05 20:57 ` Linus Torvalds
2007-04-06 0:51 ` Chris Snook
2007-04-06 1:03 ` Chris Snook
2007-04-06 1:29 ` Linus Torvalds
2007-04-06 2:15 ` Eric W. Biederman
2007-04-06 10:43 ` Robin Holt
2007-04-06 15:38 ` Eric W. Biederman
2007-04-06 16:31 ` Oleg Nesterov
2007-04-06 17:32 ` Ingo Molnar
2007-04-06 17:39 ` Roland Dreier
2007-04-06 18:04 ` Eric W. Biederman
2007-04-06 18:30 ` Eric W. Biederman
2007-04-06 19:18 ` [patch] sched: get rid of p->children use in show_task() Ingo Molnar
2007-04-06 19:22 ` Ingo Molnar [this message]
2007-04-10 13:48 ` init's children list is long and slows reaping children Ingo Molnar
2007-04-10 13:38 ` Oleg Nesterov
2007-04-10 15:00 ` Eric W. Biederman
2007-04-10 15:16 ` [PATCH] Only send pdeath_signal when getppid changes Eric W. Biederman
2007-04-10 16:37 ` Oleg Nesterov
2007-04-10 17:41 ` Eric W. Biederman
2007-04-10 17:48 ` Roland McGrath
2007-04-11 3:17 ` Albert Cahalan
2007-04-10 14:51 ` init's children list is long and slows reaping children Eric W. Biederman
2007-04-10 15:06 ` Ingo Molnar
2007-04-10 15:22 ` Eric W. Biederman
2007-04-10 15:53 ` Ingo Molnar
2007-04-10 16:17 ` Eric W. Biederman
2007-04-11 6:20 ` [patch] uninline remove/add_parent() APIs Ingo Molnar
2007-04-11 7:00 ` Eric W. Biederman
2007-04-11 22:06 ` Andrew Morton
2007-04-12 10:45 ` Eric W. Biederman
2007-04-12 22:50 ` Roland McGrath
2007-04-10 16:44 ` init's children list is long and slows reaping children Oleg Nesterov
2007-04-11 19:55 ` Bill Davidsen
2007-04-11 20:17 ` Eric W. Biederman
2007-04-11 21:24 ` Bill Davidsen
2007-04-11 20:19 ` Oleg Nesterov
2007-04-06 18:02 ` Eric W. Biederman
2007-04-06 18:21 ` Davide Libenzi
2007-04-06 18:56 ` Eric W. Biederman
2007-04-06 19:16 ` Davide Libenzi
2007-04-06 19:19 ` Ingo Molnar
2007-04-06 21:29 ` Davide Libenzi
2007-04-06 21:51 ` Linus Torvalds
2007-04-06 22:31 ` Davide Libenzi
2007-04-06 22:46 ` Linus Torvalds
2007-04-06 22:59 ` Davide Libenzi
2007-04-09 8:28 ` Ingo Molnar
2007-04-09 18:09 ` Bill Davidsen
2007-04-09 19:28 ` Kyle Moffett
2007-04-09 19:51 ` Linus Torvalds
2007-04-09 20:03 ` Davide Libenzi
2007-04-10 15:12 ` Bill Davidsen
2007-04-10 19:17 ` Davide Libenzi
2007-04-09 20:00 ` Eric W. Biederman
2007-04-06 16:41 ` Robin Holt
2007-04-09 17:37 ` Chris Snook
2007-04-06 18:05 ` Christoph Hellwig
2007-04-06 19:39 ` Eric W. Biederman
2007-04-06 22:38 ` Jeff Garzik
2007-04-06 22:51 ` Linus Torvalds
2007-04-06 23:37 ` Jeff Garzik
2007-04-11 7:28 ` Nick Piggin
2007-04-10 0:23 ` Andrew Morton
2007-04-10 0:48 ` Eric W. Biederman
2007-04-10 1:15 ` Andrew Morton
2007-04-10 6:53 ` Jeff Garzik
2007-04-10 9:42 ` Robin Holt
2007-04-10 1:59 ` Dave Jones
2007-04-10 2:30 ` Andrew Morton
2007-04-10 2:46 ` Linus Torvalds
2007-04-10 7:07 ` Jeff Garzik
2007-04-10 22:20 ` Ingo Oeser
2007-04-10 5:07 ` Alexey Dobriyan
2007-04-10 5:21 ` Dave Jones
2007-04-10 6:09 ` Torsten Kaiser
2007-04-10 7:08 ` Jeff Garzik
2007-04-10 7:05 ` Jeff Garzik
2007-04-10 7:37 ` Andrew Morton
2007-04-10 8:33 ` Jeff Garzik
2007-04-10 8:41 ` Andrew Morton
2007-04-10 8:48 ` Jeff Garzik
2007-04-10 22:35 ` Ingo Oeser
2007-04-10 16:35 ` Matt Mackall
2007-04-10 7:44 ` Russell King
2007-04-10 8:16 ` Jeff Garzik
2007-04-10 8:59 ` Ingo Molnar
2007-04-10 9:33 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070406192259.GA18722@elte.hu \
--to=mingo@elte.hu \
--cc=csnook@redhat.com \
--cc=ebiederm@xmission.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=steiner@americas.sgi.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox