Re: Linux 2.6.21-rc6

Rafael J. Wysocki
2007-04-14T18:24:34Z

On Saturday, 14 April 2007 15:00, Adrian Bunk wrote:
> On Sat, Apr 14, 2007 at 02:31:54PM +0200, Tobias Diedrich wrote:
> > Tobias Diedrich wrote:
> > > > ed746e3b18f4df18afa3763155972c5835f284c5 is first bad commit
> > > > commit ed746e3b18f4df18afa3763155972c5835f284c5
> > > > Author: Rafael J. Wysocki <rjw@sisk.pl>
> > > > Date: Sat Feb 10 01:43:32 2007 -0800
> > > >
> > > > [PATCH] swsusp: Change code ordering in disk.c
> > > >
> > > > Change the ordering of code in kernel/power/disk.c so that device_suspend() is
> > > > called before disable_nonboot_cpus() and platform_finish() is called after
> > > > enable_nonboot_cpus() and before device_resume(), as indicated by the recent
> > > > discussion on Linux-PM (cf.
> > > > http://lists.osdl.org/pipermail/linux-pm/2006-November/004164.html).
> > > >
> > > > The changes here only affect the built-in swsusp.
> > > >
> > > > [alexey.y.starikovskiy@linux.intel.com: fix LED blinking during image load]
> > > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > > > Cc: Greg KH <greg@kroah.com>
> > > > Cc: Nigel Cunningham <nigel@suspend2.net>
> > > > Cc: Patrick Mochel <mochel@digitalimplant.org>
> > > > Cc: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
> > > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > > > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> > > >
> > > > :040000 040000 7eca5b3a8f9606bc4f2ff41192ec8c9d4ca90d18 8313b674e1d1bdf6849350af06d28a89b3bb3054 M kernel
> > > >
> > > >
> > > > Now, the remaining test is to try reverting this commit from -rc6. :)
> > >
> > > Doesn't apply cleanly against -rc6, but fixes the problem when
> > > reverted from -rc1.
> >
> > Now, this was already reported in
> > http://lkml.org/lkml/2007/3/16/126
> > and I even flagged that message in my local folder, but apparently forgot
> > to follow up on it... *sigh*
>
> Unless I misunderstood something, all of the problems Maxim described in
> this email are fixed for him in -rc6.
>
> But it's quite possible that you are running into a different issue
> exposed by this commit.

Yes, it's likely.

Tobias, I'm unable to reproduce the problem with your .config, but my hardware
is certainly different. Which suspend mode do you use? If that's "platform",
can you try to use "shutdown" or "reboot" and see if that helps?

Rafael

--
If you don't have the time to read,
you don't have the time or the tools to write.
- Stephen King