Re: tg3: unable to handle null pointer dereference

Nishanth Aravamudan
2007-04-07T01:55:56Z

On 06.04.2007 [17:36:00 -0700], David Miller wrote:
> From: "Michael Chan" <mchan@broadcom.com>
> Date: Fri, 06 Apr 2007 15:57:13 -0700
>
> > On Fri, 2007-04-06 at 14:40 -0700, Nishanth Aravamudan wrote:
> >
> > > 2.6.21-rc5 is ok. 2.6.21-rc6 results in
> > >
> > > [ 14.241665] Unable to handle kernel NULL pointer dereference (address 0000000000000000)
> >
> > Sorry, I think this should fix it:
> >
> > [TG3]: Fix crash during tg3_init_one().
> >
> > The driver will crash when the chip has been initialized by EFI before
> > tg3_init_one(). In this case, the driver will call tg3_chip_reset()
> > before allocating consistent memory.
> >
> > The bug is fixed by checking for tp->hw_status before accessing it
> > during tg3_chip_reset().
> >
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
>
> Applied, thanks Michael.

FWIW, tested, no panic.

Tested-by: Nishanth Aravamudan <nacc@us.ibm.com>

Thanks,
Nish

--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center