Re: [patch] high-res timers: UP resume fix

Pavel Machek
2007-04-11T14:16:54Z

Hi!

> > > > [...] Soeren, can you confirm that you are using a !CONFIG_SMP kernel,
> > > > and if yes, does the patch below fix the resume problem for you?
> > >
> > > hm, you seem to have a CONFIG_SMP=y kernel. I dont immediately see where
> > > we re-enable interrupts in the SMP case, but could you try my patch
> > > nevertheless
> >
> > We do in on_each_cpu() unconditionally. I missed that.
>
> BTW, the on_each_cpu() in clock_was_set() is unnecessary, because
> timekeeping_resume() is always run on one CPU.

I wonder if we should add BUG_ON(interrupts_enabled) just before
enabling interrupts to catch similar mistakes early?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html