From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nigel Cunningham <ncunningham@linuxmail.org>
Subject: Re: [RFC][PATCH -mm] swsusp: Use rbtree for tracking allocated swap
Date: Sun, 8 Apr 2007 12:56:36 +0000 [thread overview]
Message-ID: <20070408125636.GB4404@ucw.cz> (raw)
In-Reply-To: <200704072320.40238.rjw@sisk.pl>
Hi!
> Some time ago we discussed the possibility of simplifying the swsusp's approach
> towards tracking the swap pages allocated by it for saving the image (so that
> they can be freed if there's an error).
>
> I think we can get back to it now, as it is a nice optimization that should
> allow us to use less memory (almost always) and improve performance a bit.
>
Well, I do not think you can measure the difference, but...
> kernel/power/power.h | 27 +---------
> kernel/power/swap.c | 18 +-----
> kernel/power/swsusp.c | 135 ++++++++++++++++++++++++++------------------------
> kernel/power/user.c | 22 +-------
> 4 files changed, 85 insertions(+), 117 deletions(-)
....as it removes code... I think we can do that. But it is 2.6.23+
material.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-04-08 12:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-07 21:20 [RFC][PATCH -mm] swsusp: Use rbtree for tracking allocated swap Rafael J. Wysocki
2007-04-07 22:06 ` Andrew Morton
2007-04-07 22:31 ` Nigel Cunningham
2007-04-07 23:13 ` Rafael J. Wysocki
2007-04-07 23:42 ` Nigel Cunningham
2007-04-08 16:47 ` Rafael J. Wysocki
2007-04-08 21:07 ` Nigel Cunningham
2007-04-09 13:03 ` Rafael J. Wysocki
2007-04-09 21:00 ` Nigel Cunningham
2007-04-08 12:56 ` Pavel Machek [this message]
2007-04-08 17:02 ` Rafael J. Wysocki
2007-04-09 12:39 ` Pavel Machek
2007-04-10 21:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070408125636.GB4404@ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox