Re: [PATCH] merge compat_ioctl.h into compat_ioctl.c

Christoph Hellwig
2007-04-08T15:12:54Z

On Sun, Apr 08, 2007 at 04:51:20PM +0200, Arnd Bergmann wrote:
> On Sunday 08 April 2007, Christoph Hellwig wrote:
> >
> > Now that there is no arch-specific compat ioctl handling left there
> > is not point in having a separate copat_ioctl.h, so merge it into
> > compat_ioctl.c
>
> Yes, definitely a good idea.
>
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> On a similar subject, how about merging include/linux/ioctl32.h and the ioctl
> bits of fs/compat.c into fs/compat_ioctl.c as well to make it completely
> self-contained?

I have a patch for that pending.