From: Andrew Morton <akpm@linux-foundation.org>
To: Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [patch] Pad irq_desc to internode cacheline size
Date: Mon, 9 Apr 2007 13:57:29 -0700 [thread overview]
Message-ID: <20070409135729.a466e9cb.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070409195356.GA5275@localhost.localdomain>
On Mon, 9 Apr 2007 12:56:27 -0700
Ravikiran G Thirumalai <kiran@scalex86.org> wrote:
> We noticed a drop in n/w performance due to the irq_desc being cacheline
> aligned rather than internode aligned. We see 50% of expected performance
> when two e1000 nics local to two different nodes have consecutive irq
> descriptors allocated, due to false sharing.
>
> Note that this patch does away with cacheline padding for the UP case, as it
> does not seem useful for UP configurations.
>
> Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
> Signed-off-by: Shai Fultheim <shai@scalex86.org>
>
> Index: linux-2.6.21-rc5/include/linux/irq.h
> ===================================================================
> --- linux-2.6.21-rc5.orig/include/linux/irq.h 2007-04-09 10:16:23.560848473 -0700
> +++ linux-2.6.21-rc5/include/linux/irq.h 2007-04-09 10:16:45.401177929 -0700
> @@ -175,7 +175,7 @@ struct irq_desc {
> struct proc_dir_entry *dir;
> #endif
> const char *name;
> -} ____cacheline_aligned;
> +} ____cacheline_internodealigned_in_smp;
>
> extern struct irq_desc irq_desc[NR_IRQS];
This will consume nearly 4k per irq won't it? What is the upper bound
here, across all configs and all hardware?
Is VSMP the only arch which has ____cacheline_internodealigned_in_smp
larger than ____cacheline_aligned_in_smp?
next prev parent reply other threads:[~2007-04-09 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 19:56 [patch] Pad irq_desc to internode cacheline size Ravikiran G Thirumalai
2007-04-09 20:57 ` Andrew Morton [this message]
2007-04-09 21:47 ` Eric W. Biederman
2007-04-09 22:09 ` Ravikiran G Thirumalai
2007-04-09 22:33 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070409135729.a466e9cb.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox