public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] intel_agp: fix G965 GTT size detect
@ 2007-04-10  1:42 Wang Zhenyu
  2007-04-10  2:10 ` Dave Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Zhenyu @ 2007-04-10  1:42 UTC (permalink / raw)
  To: Dave Jones; +Cc: LKML, Eric Anholt, Keith Packard


Dave, 

On G965, I810_PGETBL_CTL is a mmio offset, but we wrongly take it
as pci config space offset in detecting GTT size. This one line patch
fixs this. 

Signed-off-by: Wang Zhenyu <zhenyu.z.wang@intel.com>

---
diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index a9fdbf9..4c05c71 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -431,9 +431,8 @@ static void intel_i830_init_gtt_entries(
 
 	if (IS_I965) {
 		u32 pgetbl_ctl;
-
-		pci_read_config_dword(agp_bridge->dev, I810_PGETBL_CTL,
-				      &pgetbl_ctl);
+		pgetbl_ctl = readl(intel_i830_private.registers+I810_PGETBL_CTL);
+		    	
 		/* The 965 has a field telling us the size of the GTT,
 		 * which may be larger than what is necessary to map the
 		 * aperture.
---

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] intel_agp: fix G965 GTT size detect
  2007-04-10  1:42 [PATCH] intel_agp: fix G965 GTT size detect Wang Zhenyu
@ 2007-04-10  2:10 ` Dave Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2007-04-10  2:10 UTC (permalink / raw)
  To: LKML, Eric Anholt, Keith Packard

On Tue, Apr 10, 2007 at 09:42:48AM +0800, Wang Zhenyu wrote:
 > 
 > Dave, 
 > 
 > On G965, I810_PGETBL_CTL is a mmio offset, but we wrongly take it
 > as pci config space offset in detecting GTT size. This one line patch
 > fixs this. 

Thanks, applied, and pushed on to Linus for .21

Be careful with trailing whitespace btw, git-applymbox complains loudly
when merging such patches. (I fixed it up by hand this time)

	Dave

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-04-10  2:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-10  1:42 [PATCH] intel_agp: fix G965 GTT size detect Wang Zhenyu
2007-04-10  2:10 ` Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox