From: Andi Kleen <ak@suse.de>
To: David Miller <davem@davemloft.net>
Cc: hch@infradead.org, ashok.raj@intel.com,
linux-kernel@vger.kernel.org, akpm@osdl.org, gregkh@suse.de,
muli@il.ibm.com, asit.k.mallick@intel.com,
suresh.b.siddha@intel.com, anil.s.keshavamurthy@intel.com,
arjan@linux.intel.com, shaohua.li@intel.com
Subject: Re: [patch 5/8] [Intel IOMMU] Graphics driver workarounds to provide unity map
Date: Tue, 10 Apr 2007 11:12:17 +0200 [thread overview]
Message-ID: <200704101112.17869.ak@suse.de> (raw)
In-Reply-To: <20070410.020702.88477115.davem@davemloft.net>
On Tuesday 10 April 2007 11:07:02 David Miller wrote:
> From: Christoph Hellwig <hch@infradead.org>
> Date: Tue, 10 Apr 2007 09:33:51 +0100
>
> > On Mon, Apr 09, 2007 at 02:55:57PM -0700, Ashok Raj wrote:
> > > Most GFX drivers don't call standard PCI DMA APIs to allocate DMA buffer,
> > > Such drivers will be broken with IOMMU enabled. To workaround this issue,
> > > we added two options.
> >
> > All drm drivers do it. If the usual out of tree crap vendors are too
> > stupid for their own sake it's their fault.
> >
> > So NACK to this patch.
>
> That's my feeling as well, everything we care about should be using
> the proper APIs or else what is the point of them...
They can't. There is no proper API to do IOMMU mappings from user space.
And that is how Xorg on x86 works.
I had some hackish patches to enable mapping on /sys/bus/pci/.../coherent_mem, but
you need ioctls to pass out the translated address and it wasn't
exactly pretty. Still also not sure that's the right way.
-Andi
next prev parent reply other threads:[~2007-04-10 9:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 21:55 [patch 0/8] [Intel IOMMU] Support for Intel Virtualization Technology for Directed I/O Ashok Raj
2007-04-09 21:55 ` [patch 1/8] [Intel IOMMU] ACPI support " Ashok Raj
2007-04-10 3:39 ` Len Brown
2007-04-10 16:26 ` Ashok Raj
2007-04-09 21:55 ` [patch 2/8] [Intel IOMMU] Some generic search functions required to lookup device relationships Ashok Raj
2007-04-10 3:46 ` Greg KH
2007-04-10 8:11 ` Shaohua Li
2007-04-10 13:03 ` Greg KH
2007-04-11 1:40 ` Shaohua Li
2007-04-11 4:36 ` Greg KH
2007-04-11 6:10 ` Shaohua Li
2007-04-09 21:55 ` [patch 3/8] [Intel IOMMU] Generic hardware support for Intel IOMMU Ashok Raj
2007-04-09 21:55 ` [patch 4/8] [Intel IOMMU] Supporting Zero Length Reads in " Ashok Raj
2007-04-09 21:55 ` [patch 5/8] [Intel IOMMU] Graphics driver workarounds to provide unity map Ashok Raj
2007-04-10 8:33 ` Christoph Hellwig
2007-04-10 9:07 ` David Miller
2007-04-10 9:12 ` Andi Kleen [this message]
2007-04-11 2:40 ` Wang Zhenyu
2007-04-10 16:29 ` Arjan van de Ven
2007-04-09 21:55 ` [patch 6/8] [Intel IOMMU] Doc updates for Intel Virtualization Technology for Directed I/O Ashok Raj
2007-04-09 21:55 ` [patch 7/8] [Intel IOMMU] Support for legacy ISA devices Ashok Raj
2007-04-09 21:56 ` [patch 8/8] [Intel IOMMU] Preserve some Virtual Address when devices cannot address entire range Ashok Raj
2007-04-10 7:49 ` [patch 0/8] [Intel IOMMU] Support for Intel Virtualization Technology for Directed I/O Andi Kleen
2007-04-10 7:57 ` Shaohua Li
2007-04-10 8:09 ` Muli Ben-Yehuda
2007-04-10 8:20 ` Shaohua Li
2007-04-10 16:31 ` Ashok Raj
2007-04-10 8:21 ` Jeff Garzik
2007-04-10 8:27 ` Shaohua Li
2007-04-10 8:34 ` Jeff Garzik
2007-04-10 16:43 ` Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704101112.17869.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arjan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=shaohua.li@intel.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox