From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org,
Andi Kleen <ak@suse.de>,
Ravikiran G Thirumalai <kiran@scalex86.org>
Subject: Re: [patch] sched: align rq to cacheline boundary
Date: Tue, 10 Apr 2007 16:47:06 -0700 [thread overview]
Message-ID: <20070410234706.GA585@linux-os.sc.intel.com> (raw)
In-Reply-To: <20070410063656.GB23274@elte.hu>
On Tue, Apr 10, 2007 at 08:36:56AM +0200, Ingo Molnar wrote:
> the runqueue is really supposed to be cacheline-isolated at _both_ ends
> - at its beginning and at its end as well.
Then either we need to define the first element in the struct as
cacheline aligned or move into section where all the elements are
cacheline aligned. My current patch will not align it at the end.
> > Remember also that the linesize on VSMP is 4k.
>
> that sucks ...
>
> maybe, to mitigate some of the costs, do a special PER_CPU_CACHE_ALIGNED
> area that collects per-cpu fields that also have significant cross-CPU
> use and need cacheline isolation? Such cacheline-aligned variables, if
> collected separately, would pack up more tightly and would cause only
> half of the wasted space.
I will post a patch(once Jermey's page align percpu patch goes in to -mm)
thanks,
suresh
next prev parent reply other threads:[~2007-04-10 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 18:08 [patch] sched: align rq to cacheline boundary Siddha, Suresh B
2007-04-09 20:40 ` Andrew Morton
2007-04-09 21:53 ` Ravikiran G Thirumalai
2007-04-09 22:17 ` Siddha, Suresh B
2007-04-10 5:00 ` Ravikiran G Thirumalai
2007-04-10 6:36 ` Ingo Molnar
2007-04-10 23:47 ` Siddha, Suresh B [this message]
2007-04-10 7:37 ` Andi Kleen
2007-04-10 6:24 ` Ingo Molnar
2007-04-10 16:40 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070410234706.GA585@linux-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox