From: Andrew Morton <akpm@linux-foundation.org>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc.
Date: Wed, 11 Apr 2007 00:19:29 -0700 [thread overview]
Message-ID: <20070411001929.5162cf41.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070411064525.GC4343@localhost.localdomain>
On Wed, 11 Apr 2007 14:45:25 +0800 WANG Cong <xiyou.wangcong@gmail.com> wrote:
> >- snprintf(p->kobj.name,KOBJ_NAME_LEN,"%sp%d",disk->kobj.name,part);
> >+ snprintf(p->kobj.name, KOBJ_NAME_LEN, "%sp%d",
> >+ disk->kobj.name, part);
> ^^^
> Andrew, it seems that you left an additional whitespace in the above line (marked as ^^^).
>
> > else
> >- snprintf(p->kobj.name,KOBJ_NAME_LEN,"%s%d",disk->kobj.name,part);
> >+ snprintf(p->kobj.name, KOBJ_NAME_LEN, "%s%d",
> >+ disk->kobj.name, part);
> ^^^
> Also here. ;-p
Those are known as "fixes" ;)
One shouldn't mix whitespace fixes with functional changes really, but I
can't help myself.
next prev parent reply other threads:[~2007-04-11 7:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-01 7:32 [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc Cong WANG
2007-04-02 11:01 ` Cornelia Huck
2007-04-05 4:54 ` WANG Cong
2007-04-05 9:11 ` Cornelia Huck
2007-04-05 14:44 ` WANG Cong
2007-04-05 15:05 ` Cornelia Huck
2007-04-05 15:27 ` WANG Cong
2007-04-05 16:00 ` Cornelia Huck
2007-04-06 2:53 ` WANG Cong
2007-04-10 12:31 ` Cornelia Huck
2007-04-10 12:35 ` [Patch -mm] kobject: kobject_add() reference leak Cornelia Huck
2007-04-10 14:08 ` [-mm3 PATCH] (Retry) Check the return value of kobject_add and etc WANG Cong
2007-04-10 22:18 ` Andrew Morton
2007-04-11 6:45 ` WANG Cong
2007-04-11 7:19 ` Andrew Morton [this message]
2007-04-11 9:24 ` Cornelia Huck
-- strict thread matches above, loose matches on Subject: below --
2007-04-01 8:22 Parag Warudkar
2007-04-01 13:46 ` Parag Warudkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070411001929.5162cf41.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cornelia.huck@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox