Re: [PATCH 1/13] fs: convert core functions to zero_user_page

Jörn Engel
2007-04-11T14:58:22Z

On Tue, 10 April 2007 22:56:38 -0700, Andrew Morton wrote:
>
> And I'm surprised that this:
>
> +static inline void memclear_highpage_flush(struct page *page, unsigned int offset, unsigned int size)
> +{
> + return zero_user_page(page, offset, size);
> +}
>
> compiled. zero_user_page() returns void...

As does memclear_highpage_flush(). Some of my code looks like:
void some_func(...)
{
if (foo)
return do_foo(...);
if (bar)
return do_bar(...);
...
}

do_foo() and do_bar() also return void. Saves an extra line for the
return statment and the brackets.

Doesn't help in the code you quoted, of course.

Jörn

--
Measure. Don't tune for speed until you've measured, and even then
don't unless one part of the code overwhelms the rest.
-- Rob Pike