From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751130AbXDKIPW (ORCPT ); Wed, 11 Apr 2007 04:15:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751153AbXDKIPW (ORCPT ); Wed, 11 Apr 2007 04:15:22 -0400 Received: from smtp-103-wednesday.noc.nerim.net ([62.4.17.103]:2116 "EHLO mallaury.nerim.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751130AbXDKIPU (ORCPT ); Wed, 11 Apr 2007 04:15:20 -0400 Date: Wed, 11 Apr 2007 10:14:12 +0200 From: Jean Delvare To: Jan Engelhardt Cc: Linux Kernel Mailing List , i2c@lm-sensors.org Subject: Re: [PATCH 10/30] Use menuconfig objects - I2C Message-ID: <20070411101412.6c5512e7@hyperion.delvare> In-Reply-To: References: X-Mailer: Sylpheed-Claws 2.5.5 (GTK+ 2.10.6; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Jan, On Tue, 10 Apr 2007 23:11:41 +0200 (MEST), Jan Engelhardt wrote: > > Use menuconfigs instead of menus, so the whole menu can be disabled at > once instead of going through all options. > > Signed-off-by: Jan Engelhardt Well, in practice it was already possible to disable all I2C options at once. The real difference is that it's now done directly from the main Device Drivers menu. And we no longer have to express the dependency on I2C in each Kconfig entry, which is nice. The patch looks OK to me, except that it needs to be adjusted for the current state of the i2c subsystem. This kind of patch should be built on top on Andrew Morton's latest tree, not Linus Torvalds'. What is the merge plan? -- Jean Delvare