From: Sam Ravnborg <sam@ravnborg.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Jan Engelhardt <jengelh@linux01.gwdg.de>,
Al Boldi <a1426z@gawab.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/30] Use menuconfig objects
Date: Wed, 11 Apr 2007 19:30:48 +0200 [thread overview]
Message-ID: <20070411173048.GA28211@uranus.ravnborg.org> (raw)
In-Reply-To: <461D1291.2060703@s5r6.in-berlin.de>
On Wed, Apr 11, 2007 at 06:53:37PM +0200, Stefan Richter wrote:
> Jan Engelhardt wrote:
> > On Apr 11 2007 07:42, Al Boldi wrote:
> >>Also, I don't think it's necessary to touch any of the "depends on"; keep
> >>them as is, as they don't hurt staying that way, and may actually be
> >>necessary under certain circumstances. (see EMBEDDED)
> >
> > Simplifying the depends lines is a good thing IMO.
>
> If explicit dependency statements are replaced by if--endif blocks, does
> this count as simplification?
Applied with some common sense - yes.
if --endif blocks has been used in several places to make dependencies consistent.
When cleaning up the net part I recall a few places where the explicit dependency
was missing causing 1) dependencies to be wrong and 2) caused indention in menu-
config to be wrong.
But yet agin do not go and replace all dependencies with if--endif blocks.
They shall be used with some good taste.
Sam
next prev parent reply other threads:[~2007-04-11 17:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 22:12 [PATCH 0/30] Use menuconfig objects Al Boldi
2007-04-10 22:30 ` Jan Engelhardt
2007-04-11 4:42 ` Al Boldi
2007-04-11 7:48 ` Jan Engelhardt
2007-04-11 16:53 ` Stefan Richter
2007-04-11 17:05 ` Jan Engelhardt
2007-04-11 17:30 ` Sam Ravnborg [this message]
2007-04-11 18:32 ` Al Boldi
-- strict thread matches above, loose matches on Subject: below --
2007-04-10 19:17 Jan Engelhardt
2007-04-10 22:04 ` Stefan Richter
2007-04-10 21:40 ` David Lang
2007-04-10 22:41 ` Stefan Richter
2007-04-10 22:09 ` Jan Engelhardt
2007-04-10 23:19 ` Adrian Bunk
2007-04-11 5:52 ` Robert P. J. Day
2007-04-12 22:50 ` Andrew Morton
2007-04-12 23:07 ` Randy Dunlap
2007-04-12 23:18 ` Jan Engelhardt
2007-04-12 23:30 ` Randy Dunlap
2007-04-12 23:16 ` Jan Engelhardt
2007-04-12 23:35 ` Andrew Morton
2007-04-13 9:50 ` Jean Delvare
2007-04-13 16:02 ` Jan Engelhardt
2007-05-10 22:38 ` Andrew Morton
2007-05-11 6:05 ` Jan Engelhardt
2007-05-11 6:18 ` Andrew Morton
2007-05-11 7:47 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070411173048.GA28211@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=a1426z@gawab.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox