From: Nate Diller <nate.diller@gmail.com>
To: Andrew Morton <akpm@osdl.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Roman Zippel <zippel@linux-m68k.org>,
Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>,
David Woodhouse <dwmw2@infradead.org>,
Dave Kleikamp <shaggy@austin.ibm.com>,
Anton Altaparmakov <aia21@cantab.net>,
Evgeniy Dushistov <dushistov@mail.ru>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
reiserfs-dev@namesys.com
Subject: [PATCH 0/17] fs: cleanup single page synchronous read interface
Date: Wed, 11 Apr 2007 19:49:38 -0700 [thread overview]
Message-ID: <20070412024938.27380.54538.patchbomb.py@localhost> (raw)
Nick Piggin recently changed the read_cache_page interface to be
synchronous, which is pretty much what the file systems want anyway. Turns
out that they have more in common than that, though, and some of them want
to be able to get an uptodate *locked* page. Many of them want a kmapped
page, which is uptodate and unlocked, and they all have their own individual
helper functions to achieve this.
Since the helper functions are so similar, this patch just combines them
into a small number of simple library functions, which call read_cache_page
(renamed to __read_cache_page because it now returns a locked page). The
immediate result is a vast reduction in the number of fs-specific helper
functions. The secondary goal is to reduce the number of places the page
lock is taken, and eliminate a lot of PageUptodate and PageError checks.
The file systems that still use PageChecked now have checker functions that
return an error if the page is corrupted or has some other error. This
simplifies the logic since the checker function is not part of any helper
function anymore.
Compile tested on x86_64.
Signed-off-by: Nate Diller <nate.diller@gmail.com>
---
drivers/mtd/devices/block2mtd.c | 28 +------
fs/afs/dir.c | 56 +++-----------
fs/afs/mntpt.c | 10 --
fs/cramfs/inode.c | 3
fs/ext2/dir.c | 82 ++++++++-------------
fs/freevxfs/vxfs_extern.h | 1
fs/freevxfs/vxfs_inode.c | 2
fs/freevxfs/vxfs_lookup.c | 4 -
fs/freevxfs/vxfs_subr.c | 33 --------
fs/hfs/bnode.c | 4 -
fs/hfsplus/bnode.c | 4 -
fs/jffs2/fs.c | 27 -------
fs/jffs2/gc.c | 15 ++-
fs/jfs/jfs_metapage.c | 5 -
fs/minix/dir.c | 59 ++++-----------
fs/ntfs/aops.h | 67 -----------------
fs/ntfs/bitmap.c | 8 +-
fs/ntfs/dir.c | 65 ++++++-----------
fs/ntfs/index.c | 12 +--
fs/ntfs/lcnalloc.c | 6 -
fs/ntfs/logfile.c | 12 +--
fs/ntfs/mft.c | 53 +++++--------
fs/ntfs/super.c | 38 ++++-----
fs/ntfs/usnjrnl.c | 4 -
fs/partitions/check.c | 14 +--
fs/reiser4/plugin/file/tail_conversion.c | 8 --
fs/reiser4/plugin/item/extent_file_ops.c | 9 --
fs/reiserfs/xattr.c | 48 ++----------
fs/sysv/dir.c | 19 +---
fs/ufs/balloc.c | 8 +-
fs/ufs/dir.c | 90 +++++++++--------------
fs/ufs/truncate.c | 8 +-
fs/ufs/util.c | 52 -------------
fs/ufs/util.h | 10 --
include/linux/pagemap.h | 53 ++++++++++++-
mm/filemap.c | 118 +++++++------------------------
36 files changed, 315 insertions(+), 720 deletions(-)
next reply other threads:[~2007-04-12 2:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 2:49 Nate Diller [this message]
2007-04-12 2:49 ` [PATCH 15/17] sysv: convert dir_get_page to read_kmap_page Nate Diller
2007-04-12 2:49 ` [PATCH 1/17] cramfs: use read_mapping_page Nate Diller
2007-04-12 9:54 ` Christoph Hellwig
2007-04-12 11:26 ` Roman Zippel
2007-04-12 18:36 ` Nate Diller
2007-04-12 2:49 ` [PATCH 13/17] reiser4: remove redundant read_mapping_page error checks Nate Diller
2007-04-12 2:49 ` [PATCH 8/17] jfs: use locking read_mapping_page Nate Diller
2007-04-12 2:49 ` [PATCH 11/17] ntfs: convert ntfs_map_page to read_kmap_page Nate Diller
2007-04-12 2:49 ` [PATCH 14/17] reiserfs: convert reiserfs_get_page " Nate Diller
2007-04-12 2:49 ` [PATCH 10/17] mtd: convert page_read " Nate Diller
2007-04-12 2:49 ` [PATCH 16/17] ufs: convert ufs_get_page " Nate Diller
2007-04-12 2:49 ` [PATCH 2/17] fs: introduce new read_cache_page interface Nate Diller
2007-04-12 2:49 ` [PATCH 12/17] partition: remove redundant read_mapping_page error checks Nate Diller
2007-04-12 2:49 ` [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache_page Nate Diller
2007-04-12 11:40 ` Phillip Lougher
2007-04-12 18:29 ` Nate Diller
2007-04-12 18:53 ` Phillip Lougher
2007-04-15 10:52 ` David Woodhouse
2007-04-12 2:49 ` [PATCH 4/17] ext2: convert ext2_get_page to read_kmap_page Nate Diller
2007-04-12 2:49 ` [PATCH 9/17] minix: convert dir_get_page " Nate Diller
2007-04-12 2:49 ` [PATCH 3/17] afs: convert afs_dir_get_page " Nate Diller
2007-04-12 10:58 ` David Howells
2007-04-12 18:23 ` Nate Diller
2007-04-12 18:57 ` David Howells
2007-04-12 19:21 ` Andrew Morton
2007-04-12 19:29 ` David Howells
2007-07-16 6:05 ` Drop patch update-isdn-tree-to-use-pci_get_device.patch from -mm tree Surya Prabhakar N
2007-04-12 19:27 ` [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page Nate Diller
2007-04-12 19:43 ` David Howells
2007-04-12 2:49 ` [PATCH 17/17] vxfs: convert vxfs_get_page " Nate Diller
2007-04-12 2:49 ` [PATCH 6/17] hfs: remove redundant read_mapping_page error check Nate Diller
2007-04-12 2:49 ` [PATCH 5/17] hfsplus: " Nate Diller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070412024938.27380.54538.patchbomb.py@localhost \
--to=nate.diller@gmail.com \
--cc=aia21@cantab.net \
--cc=akpm@osdl.org \
--cc=dushistov@mail.ru \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=reiserfs-dev@namesys.com \
--cc=shaggy@austin.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox