Re: [nameidata 2/2] Pass no useless nameidata to the create, lookup, and permission IOPs

Randy Dunlap
2007-04-16T16:40:15Z

On Mon, 16 Apr 2007 18:29:20 +0200 Andreas Gruenbacher wrote:

> Here is a patch with request for comment.
>
> --- a/include/linux/namei.h
> +++ b/include/linux/namei.h
> @@ -14,21 +14,39 @@ struct open_intent {
>
> enum { MAX_NESTED_LINKS = 8 };
>
> +/**

Please don't use the kernel-doc begin-marker "/**" when the comment block
isn't in kernel-doc format.

> + * Fields shared between nameidata and nameidata2 -- nameidata2 could
> + * be embedded in nameidata, but then the vfs code would become
> + * cluttered with dereferences.
> + */
> +#define __NAMEIDATA2 \
> + struct dentry *dentry; \
> + struct vfsmount *mnt; \
> + unsigned int flags; \
> + \
> + union { \
> + struct open_intent open; \
> + } intent;
> +

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***