From: Benjamin LaHaise <bcrl@kvack.org>
To: Ken Chen <kenchen@google.com>
Cc: Zach Brown <zach.brown@oracle.com>,
akpm@linux-foundation.org, linux-aio@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch] convert aio event reap to use atomic-op instead of spin_lock
Date: Thu, 12 Apr 2007 11:13:25 -0400 [thread overview]
Message-ID: <20070412151325.GQ13621@kvack.org> (raw)
In-Reply-To: <20070412143131.GP13621@kvack.org>
On Thu, Apr 12, 2007 at 10:31:31AM -0400, Benjamin LaHaise wrote:
> On Thu, Apr 12, 2007 at 12:50:39AM -0700, Ken Chen wrote:
> > I ran through the autotest (with bug fix in the test code). It passes
> > the regression tests. I made the following change since last rev:
>
> By removing the spinlock around ring insertion, you've made it possible
> for two events being inserted on different CPUs to end up creating
> inconsistent state, as there is nothing which guarantees that resulting
> event in the ring will be wholely one event or another.
Ignore that, I misread the function it was applied to. -ENEEDCOFFEE. Yes,
that spinlock can go if we're doing cmpxchg().
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <zyntrop@kvack.org>.
prev parent reply other threads:[~2007-04-12 15:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 23:53 [patch] convert aio event reap to use atomic-op instead of spin_lock Ken Chen
2007-04-11 5:18 ` Andrew Morton
2007-04-11 16:54 ` Ken Chen
2007-04-11 18:15 ` Zach Brown
2007-04-11 18:29 ` Ken Chen
2007-04-11 18:00 ` Zach Brown
2007-04-11 19:11 ` Andrew Morton
2007-04-11 19:34 ` Zach Brown
2007-04-11 19:28 ` Ken Chen
2007-04-11 19:44 ` Zach Brown
2007-04-11 19:45 ` Benjamin LaHaise
2007-04-11 19:52 ` Zach Brown
2007-04-11 20:03 ` Benjamin LaHaise
2007-04-12 7:29 ` Ken Chen
2007-04-12 12:06 ` Jeff Moyer
2007-04-13 0:57 ` Ken Chen
2007-04-13 1:08 ` Ken Chen
2007-04-12 7:50 ` Ken Chen
2007-04-12 14:31 ` Benjamin LaHaise
2007-04-12 15:13 ` Benjamin LaHaise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070412151325.GQ13621@kvack.org \
--to=bcrl@kvack.org \
--cc=akpm@linux-foundation.org \
--cc=kenchen@google.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox