[KJ][PATCH 03/04]use set_current_state in fs

[KJ][PATCH 03/04]use set_current_state in fs

[Milind Arun Choudhary]

use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs

Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>


---
 idmap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
index 9d4a6b2..054ca15 100644
--- a/fs/nfs/idmap.c
+++ b/fs/nfs/idmap.c
@@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashtable *h,
 	set_current_state(TASK_UNINTERRUPTIBLE);
 	mutex_unlock(&idmap->idmap_im_lock);
 	schedule();
-	current->state = TASK_RUNNING;
+	set_current_state(TASK_RUNNING);
 	remove_wait_queue(&idmap->idmap_wq, &wq);
 	mutex_lock(&idmap->idmap_im_lock);
 
@@ -333,7 +333,7 @@ nfs_idmap_name(struct idmap *idmap, struct idmap_hashtable *h,
 	set_current_state(TASK_UNINTERRUPTIBLE);
 	mutex_unlock(&idmap->idmap_im_lock);
 	schedule();
-	current->state = TASK_RUNNING;
+	set_current_state(TASK_RUNNING);
 	remove_wait_queue(&idmap->idmap_wq, &wq);
 	mutex_lock(&idmap->idmap_im_lock);
 
-- 
Milind Arun Choudhary

Re: [KJ][PATCH 03/04]use set_current_state in fs

[Eric Dumazet]

Milind Arun Choudhary a écrit :
> use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs
> 
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
> 
> 
> ---
>  idmap.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
> index 9d4a6b2..054ca15 100644
> --- a/fs/nfs/idmap.c
> +++ b/fs/nfs/idmap.c
> @@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashtable *h,
>  	set_current_state(TASK_UNINTERRUPTIBLE);
>  	mutex_unlock(&idmap->idmap_im_lock);
>  	schedule();
> -	current->state = TASK_RUNNING;
> +	set_current_state(TASK_RUNNING);
>  	remove_wait_queue(&idmap->idmap_wq, &wq);
>  	mutex_lock(&idmap->idmap_im_lock);

Probably a dumb question, so please forgive me.

Why are you  forcing a memory barrier here, (and also on your other patches).

Is'nt a  __set_current_state(TASK_RUNNING); appropriate ?

Re: [KJ][PATCH 03/04]use set_current_state in fs

[Milind Arun Choudhary]

On 11:39 Sat 14 Apr     , Eric Dumazet wrote:
> Milind Arun Choudhary a écrit :
> >use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs
> Probably a dumb question, so please forgive me.
no.
you have a valid point

My bad :(
I should probably be enjoying my weekend outdoors..
breath some fresh air...
rather than sending such dumb patches..

ummmmmmmm
booting into  windows might help :)

> Why are you  forcing a memory barrier here, (and also on your other 
> patches).
> Is'nt a  __set_current_state(TASK_RUNNING); appropriate ?
it is..

would resend later

Njo!!!
-- 
Milind Arun Choudhary